VPC Endpoints should add Name tag by default

[aldenquimby]

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

When adding vpc-endpoints, I currently add a tag for Name on each, like this:

    execute-api = {
      service = "execute-api"
      tags    = { Name = "execute-api-vpc-endpoint" }
    }
    textract-fips = {
      service = "textract-fips"
      tags    = { Name = "textract-fips-vpc-endpoint" }
    }
    transcribe = {
      service = "transcribe"
      tags    = { Name = "transcribe-vpc-endpoint" }
    }

Describe the solution you'd like.

It would be nice if Name tags were auto-added if service is specified, so I could do this instead:

    execute-api = {
      service = "execute-api"
    }
    textract-fips = {
      service = "textract-fips"
    }
    transcribe = {
      service = "transcribe"
    }

Describe alternatives you've considered.

Manually specifying Names works, it's just verbose

Additional context

• The security group within the vpc-endpoints module already auto-adds a Name tag, which is nice:
  

  terraform-aws-vpc/modules/vpc-endpoints/main.tf

  Lines 68 to 72 in 9ffd9c6

  	tags = merge(
  	var.tags,
  	var.security_group_tags,
  	{ "Name" = try(coalesce(var.security_group_name, var.security_group_name_prefix), "") },
  	)

[sebastianczech]

@aldenquimby I prepared PR #1151 , which I hope resolves your problem

[aldenquimby]

@sebastianczech excellent! Thank you. Exactly what I was hoping for