Skip to content

fix: update cloud run tflint #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: update cloud run tflint #179

merged 1 commit into from
Feb 3, 2023

Conversation

bharathkkb
Copy link
Member

No description provided.

@comment-bot-dev
Copy link

@bharathkkb
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody changed the title chore: update cloud run tflint fix: update cloud run tflint Jan 23, 2023
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb - I'd recommend this at least be a "fix" due to the changes in modules/cloud_run_services_iam

@imrannayer
Copy link
Collaborator

@bharathkkb can you plz merge this so I can work on next submodule? My tests are failing due to this issue.

@apeabody apeabody merged commit 3d72db5 into master Feb 3, 2023
@apeabody apeabody deleted the fix-lint branch February 3, 2023 22:46
@bharathkkb
Copy link
Member Author

Thanks @apeabody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants