Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabling the storage submodule to allow public access prevention #181

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Saloni-Patidar
Copy link
Contributor

fix for issue #169
"The storage submodule should allow public access prevention #169"

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@Saloni-Patidar
Copy link
Contributor Author

@imrannayer cloud build is failing with error :
Error: googleapi: Error 429: Existing sinks count: 200 is greater than the limit: 200.

Can you help fix this?

@imrannayer
Copy link
Collaborator

/gcbrun

@Saloni-Patidar
Copy link
Contributor Author

@imrannayer Can you please approve this merge request if we are good to go? If not, please let me know.

imrannayer
imrannayer previously approved these changes Nov 1, 2023
Copy link
Collaborator

@imrannayer imrannayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imrannayer imrannayer dismissed their stale review November 1, 2023 16:30

Need one more change

@imrannayer
Copy link
Collaborator

@Saloni-Patidar Can you plz change min provider version to 4.42 in version.tf file. Feature was GA in provider 4.42.

@imrannayer imrannayer self-requested a review November 1, 2023 16:32
@Saloni-Patidar
Copy link
Contributor Author

@imrannayer updated the version.

@g-awmalik
Copy link
Contributor

/gcbrun

@Saloni-Patidar
Copy link
Contributor Author

@imrannayer @g-awmalik the pipeline is failing, can you help with that?

@g-awmalik
Copy link
Contributor

@imrannayer @g-awmalik the pipeline is failing, can you help with that?

This seems like a TGP version issue. Investigating....

@g-awmalik
Copy link
Contributor

/gcbrun

4 similar comments
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 196eb71 into terraform-google-modules:master Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants