-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: ✨ added bigquery subcription capability #101
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
87b3201
to
0ef19f0
Compare
Hello! Could somebody share the output of the failed cicd so that i may fix it please? |
Hi @rs1986x - Thanks for the contribution! The CI error appeared to be unrelated, so I just triggered a re-run. Cheers! |
Hi @rs1986x - I haven't checked if this is related to your change (duplicate pubsub topic?), but passing along the current CI error:
|
Hi @apeabody - where is the issue? is it applying the example? just to understand where the failure is so i can help to fix it. |
@rs1986x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rs1986x for the contribution!
Hi! I wanted to integrate the recently released push to bigquery functionality from google provider 4.32.
I tested as thoroughly as possible on our dev setup, i have to say though i was not able to run the kitchen tests, i can't follow the instructions to the letter give some accounts and privileges constraint that i have. I tried to run it against an already existing project but i was not able to, maybe you can help with that.
Thanks for the consideration, any feedback is highly appreciated
BEGIN_COMMIT_OVERRIDE
feat!: ✨ added bigquery subscription capability, require TPG >= 4.32 #101
END_COMMIT_OVERRIDE