Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: ✨ added bigquery subcription capability #101

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

rs1986x
Copy link
Contributor

@rs1986x rs1986x commented Aug 16, 2022

Hi! I wanted to integrate the recently released push to bigquery functionality from google provider 4.32.

I tested as thoroughly as possible on our dev setup, i have to say though i was not able to run the kitchen tests, i can't follow the instructions to the letter give some accounts and privileges constraint that i have. I tried to run it against an already existing project but i was not able to, maybe you can help with that.

Thanks for the consideration, any feedback is highly appreciated

BEGIN_COMMIT_OVERRIDE
feat!: ✨ added bigquery subscription capability, require TPG >= 4.32 #101
END_COMMIT_OVERRIDE

@google-cla
Copy link

google-cla bot commented Aug 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rs1986x rs1986x force-pushed the master branch 7 times, most recently from 87b3201 to 0ef19f0 Compare August 18, 2022 12:55
@rs1986x
Copy link
Contributor Author

rs1986x commented Oct 4, 2022

Hello! Could somebody share the output of the failed cicd so that i may fix it please?
P.S. i have been using the module for a while now with no problems

@apeabody
Copy link
Contributor

apeabody commented Oct 4, 2022

Hi @rs1986x - Thanks for the contribution! The CI error appeared to be unrelated, so I just triggered a re-run. Cheers!

@apeabody
Copy link
Contributor

apeabody commented Oct 4, 2022

Hi @rs1986x - I haven't checked if this is related to your change (duplicate pubsub topic?), but passing along the current CI error:

│ Error: Error creating Topic: googleapi: Error 409: Resource already exists in the project (resource=cft-tf-pubsub-topic).
│ 
│   with module.pubsub.google_pubsub_topic.topic[0],
│   on ../../main.tf line 106, in resource "google_pubsub_topic" "topic":
│  106: resource "google_pubsub_topic" "topic" {
│ 
╵}

@rs1986x
Copy link
Contributor Author

rs1986x commented Oct 5, 2022

t checked if this is related to your change (duplicate pubsub topic?), but passing along the current CI error:

Hi @apeabody - where is the issue? is it applying the example? just to understand where the failure is so i can help to fix it.

examples/bigquery/main.tf Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@rs1986x
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody changed the title feat: ✨ added bigquery subcription capability feat!: ✨ added bigquery subcription capability Oct 6, 2022
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rs1986x for the contribution!

@apeabody apeabody merged commit 466a9ec into terraform-google-modules:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants