Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't grant fwding permissions if no DLT present #108

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix: don't grant fwding permissions if no DLT present #108

merged 2 commits into from
Nov 14, 2022

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented Oct 25, 2022 •
edited
Loading

Additional permissions must be granted to Pub/Sub if a DLT is configured in a subscription as per https://cloud.google.com/pubsub/docs/handling-failures#grant_forwarding_permissions

However if no DLT is configured for the subscription, these resources needn't be created.

closes #107

@naseemkullah
Don't grant fwding permissions if no DLT present
d21ece1 
Additional permissions must be granted to Pub/Sub if a DLT is configured
in a subscription as per https://cloud.google.com/pubsub/docs/handling-failures#grant_forwarding_permissions

However if no DLT is configured for the subscription, these resources
needn't be created.

Signed-off-by: Naseem Ullah <24660299+naseemkullah@users.noreply.github.com>
@naseemkullah naseemkullah mentioned this pull request Oct 25, 2022
Merged
@naseemkullah naseemkullah changed the title Don't grant fwding permissions if no DLT present fix: don't grant fwding permissions if no DLT present Oct 25, 2022
@naseemkullah
Copy link
Contributor Author

@bharathkkb PTAL 🙏

bharathkkb
bharathkkb approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @naseemkullah

@comment-bot-dev
Copy link

@naseemkullah
Thanks for the PR! 🚀
✅ Lint checks have passed.

@naseemkullah
Copy link
Contributor Author

Thanks for the fix @naseemkullah

My pleasure.

@bharathkkb bharathkkb merged commit 52c3b13 into terraform-google-modules:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleanup config when no dead letter topic present
3 participants
@naseemkullah @comment-bot-dev @bharathkkb