Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added pre-wired rule for IS -> COS #302

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat: added pre-wired rule for IS -> COS #302

merged 7 commits into from
Oct 12, 2023

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Sep 21, 2023

Description

Added pre-wired rule for IS -> COS

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 25, 2023

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 25, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 4, 2023

/run pipeline

vburckhardt
vburckhardt requested changes Oct 9, 2023
View reviewed changes
examples/fscloud/variables.tf Outdated Show resolved Hide resolved
@Ak-sky Ak-sky requested a review from vburckhardt October 9, 2023 21:19
vburckhardt
vburckhardt previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 11, 2023

/run pipeline

@Ak-sky Ak-sky requested a review from vburckhardt October 11, 2023 14:08
@vburckhardt vburckhardt merged commit 2e8521d into main Oct 12, 2023
@vburckhardt vburckhardt deleted the is-to-cos branch October 12, 2023 09:49
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vburckhardt vburckhardt vburckhardt approved these changes

@jojustin jojustin Awaiting requested review from jojustin

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ak-sky @terraform-ibm-modules-ops @vburckhardt