Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong eventgrid schema validation #28

Closed
johejo opened this issue Jun 30, 2020 · 1 comment · Fixed by #31
Closed

wrong eventgrid schema validation #28

johejo opened this issue Jun 30, 2020 · 1 comment · Fixed by #31
Labels
bug Something isn't working

Comments

@johejo
Copy link

johejo commented Jun 30, 2020

Values that are correct in azure-api-spec are output with an error.
CloudEventSchemaV1_0 is supposed to be correct value.
https://github.com/Azure/azure-rest-api-specs/blob/e917ed8c8c5d5b3d1c3f844f17788e6192122cb1/specification/eventgrid/resource-manager/Microsoft.EventGrid/stable/2020-06-01/EventGrid.json#L3281

But tflint output is

Error: "CloudEventSchemaV1_0" is an invalid value as event_delivery_schema (azurerm_eventgrid_event_subscription_invalid_event_delivery_schema)

  on main.tf line 415:
 415:   event_delivery_schema = "CloudEventSchemaV1_0"

Reference: https://github.com/terraform-linters/tflint-ruleset-azurerm/blob/v0.2.0/docs/rules/azurerm_eventgrid_event_subscription_invalid_event_delivery_schema.md

my tflint version

$ tflint --version
TFLint version 0.17.0
+ ruleset.azurerm (0.2.0)
@wata727
Copy link
Member

wata727 commented Jun 30, 2020

@johejo Thank you for opening the issue.

The current rule refers to this definition:
https://github.com/Azure/azure-rest-api-specs/blob/e917ed8c8c5d5b3d1c3f844f17788e6192122cb1/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2019-02-01-preview/EventGrid.json#L2686-L2698

So, it seems that this can be improved by updating the API version to the latest version.

Since this project has just begun, we really want the voices of Azure users. Please let me know if you have any problems. Thanks again!

@wata727 wata727 added the bug Something isn't working label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants