Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DynamoDb as an AWS DMS target #1002

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Add support for DynamoDb as an AWS DMS target #1002

merged 2 commits into from
Jun 29, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 29, 2017 •
edited
Loading

This is a port of @chrisjharding's work in hashicorp/terraform#15163

Fixes: #797

I used his patch, then added the docs, and a retry on the Endpoint Create to allow for IAM Role eventual consistency

% make testacc TEST=./aws TESTARGS='-run=TestAccAwsDmsEndpoint'                                                           2 ↵ ✹ ✭
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsDmsEndpoint -timeout 120m
=== RUN   TestAccAwsDmsEndpointBasic
--- PASS: TestAccAwsDmsEndpointBasic (75.60s)
=== RUN   TestAccAwsDmsEndpointDynamoDb
--- PASS: TestAccAwsDmsEndpointDynamoDb (65.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	141.367s

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 29, 2017
@stack72 stack72 mentioned this pull request Jun 29, 2017
Closed
grubernaut
grubernaut approved these changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

aws/resource_aws_dms_endpoint.go Outdated
@@ -4,9 +4,12 @@ import (
"log"
"strings"

"time"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort imports here

@stack72
resource/aws_dms_endpoint: Add retry to allow IAM to propagate
7d3d642 
Allows the IAM Role for DynamoDB to propagate for use in DMS Endpoint
@stack72 stack72 merged commit c82b217 into master Jun 29, 2017
@stack72 stack72 deleted the b-aws-dms-dynamodb branch June 29, 2017 17:31
@chrisjharding chrisjharding mentioned this pull request Aug 18, 2017
Merged
@microamp microamp mentioned this pull request May 6, 2018
Merged
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for dymanodb as dms endpoint
3 participants
@stack72 @grubernaut @chrisjharding