fix: remove client-vpn endpoints from state when they are missing

[GabrielCastro]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

BUG FIXES:
resource/client_vpn_endpoint: Fix crash after an endpoint has been removed outside terraform

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bflad]

Thanks for fixing this, @GabrielCastro 🚀 We can test this code via:

func TestAccAwsEc2ClientVpnEndpoint_disappears(t *testing.T) {
	rStr := acctest.RandString(5)

	resource.ParallelTest(t, resource.TestCase{
		PreCheck:     func() { testAccPreCheck(t) },
		Providers:    testAccProvidersWithTLS,
		CheckDestroy: testAccCheckAwsEc2ClientVpnEndpointDestroy,
		Steps: []resource.TestStep{
			{
				Config: testAccEc2ClientVpnEndpointConfig(rStr),
				Check: resource.ComposeTestCheckFunc(
					testAccCheckAwsEc2ClientVpnEndpointExists("aws_ec2_client_vpn_endpoint.test"),
					testAccCheckAwsEc2ClientVpnEndpointDisappears("aws_ec2_client_vpn_endpoint.test"),
				),
				ExpectNonEmptyPlan: true,
			},
		},
	})
}

func testAccCheckAwsEc2ClientVpnEndpointDisappears(name string) resource.TestCheckFunc {
	return func(s *terraform.State) error {
		rs, ok := s.RootModule().Resources[name]
		if !ok {
			return fmt.Errorf("Not found: %s", name)
		}

		conn := testAccProvider.Meta().(*AWSClient).ec2conn

		input := &ec2.DeleteClientVpnEndpointInput{
			ClientVpnEndpointId: aws.String(rs.Primary.ID),
		}

		_, err := conn.DeleteClientVpnEndpoint(input)

		return err
	}
}

Previously before code update:

--- FAIL: TestAccAwsEc2ClientVpnEndpoint_disappears (14.36s)
    testing.go:569: Step 0 error: errors during follow-up refresh:

        Error: Error reading Client VPN endpoint: InvalidClientVpnEndpointId.NotFound: Endpoint cvpn-endpoint-0f615b0f07cfbe2ba does not exist

Output from acceptance testing:

--- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (16.12s)

[ghost]

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!