resource/aws_ssm_parameter: ForceNew on ssm_parameter rename #1022
Conversation
| @@ -183,6 +202,16 @@ resource "aws_ssm_parameter" "foo" { | |||
| `, rName, value) | |||
| } | |||
|
|
|||
| func testAccAWSSSMParameterBasicConfigChangeName(rName string, value string) string { | |||
There was a problem hiding this comment.
What is the reason for having a copy of testAccAWSSSMParameterBasicConfig with a different name instead of just passing a different name as argument? 🙂
| { | ||
| Config: testAccAWSSSMParameterBasicConfigChangeName(name, "baz1"), | ||
| PlanOnly: true, | ||
| ExpectNonEmptyPlan: true, |
There was a problem hiding this comment.
I think this test isn't testing the new behaviour. 🤔 (a) It is changing the value, not the name. (b) even if it was changing the name, we'd still need to check existence of the old SSM parameter via API as it gets wiped from state, so testAccCheckAWSSSMParameterDestroy wouldn't catch it.
radeksimko
added
the
waiting-response
stack72
force-pushed
the
b-aws-ssm-param-forcenew
branch
from
09e8b8d
to
e6f3842
Compare
|
@radeksimko you are correct - the test wasn't correct. This has been updated now and it checks the API to make sure that the old Parameter has been removed :) |
Fixes: #1008 There doesn't seem to be a way to change the name of an AWS SSM Parameter. Therefore, it should be marked as ForceNew. ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMParameter_ -timeout 120m === RUN TestAccAWSSSMParameter_basic --- PASS: TestAccAWSSSMParameter_basic (25.06s) === RUN TestAccAWSSSMParameter_update --- PASS: TestAccAWSSSMParameter_update (43.21s) === RUN TestAccAWSSSMParameter_changeNameForcesNew --- PASS: TestAccAWSSSMParameter_changeNameForcesNew (40.84s) === RUN TestAccAWSSSMParameter_secure --- PASS: TestAccAWSSSMParameter_secure (37.90s) === RUN TestAccAWSSSMParameter_secure_with_key --- PASS: TestAccAWSSSMParameter_secure_with_key (73.26s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 220.297s ```
stack72
force-pushed
the
b-aws-ssm-param-forcenew
branch
from
e6f3842
to
4d39166
Compare
| } | ||
|
|
||
| resp, err := conn.GetParameters(paramInput) | ||
| if err != nil { |
There was a problem hiding this comment.
as mentioned on Slack - I'm surprised this doesn't return a 404 but ¯_(ツ)_/¯
There was a problem hiding this comment.
It will return an empty response object :) But a response none the less
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Fixes: #1008
There doesn't seem to be a way to change the name of an AWS SSM
Parameter. Therefore, it should be marked as ForceNew.