Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Adding IAM Instance Profile Datasource #1024

Merged

Conversation

yanndegat
Copy link
Contributor

No description provided.

@stack72 stack72 added the new-data-source Introduces a new data source. label Jun 30, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 30, 2017

Hi @yanndegat

Thanks so much for this :) This LGTM!

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMInstanceProfile'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMInstanceProfile -timeout 120m
=== RUN   TestAccAWSDataSourceIAMInstanceProfile_basic
--- PASS: TestAccAWSDataSourceIAMInstanceProfile_basic (29.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.943s

@stack72 stack72 merged commit 1606270 into hashicorp:master Jun 30, 2017
@yanndegat
Copy link
Contributor Author

@stack72 thanks to you!

i don't know if you realize what a pleasure it is to work with terraform
knowing that if something is missing and without overrated programming skills, you can
code it, submit it and it will be reviewed, merged and released so quickly.
you've built a great tool and a great community.

once again, thanks to you!

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants