Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow snapshot copy grants to be imported #10350

Merged
merged 1 commit into from
Apr 7, 2020
Merged

allow snapshot copy grants to be imported #10350

merged 1 commit into from
Apr 7, 2020

Conversation

f0rk
Copy link
Contributor

@f0rk f0rk commented Oct 2, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add import for aws_redshift_snapshot_copy_grant.

@f0rk f0rk requested a review from a team October 2, 2019 20:11
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. labels Oct 2, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 17, 2020
@bflad bflad added this to the v2.57.0 milestone Apr 7, 2020
bflad
bflad reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @f0rk 👋 Thank you for submitting this and apologies for the delayed review. This will be merged in with some accompanying acceptance testing and documentation to follow the Contributing Guide.

Output from acceptance testing:

--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (18.21s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (42.92s)

bflad added a commit that referenced this pull request Apr 7, 2020
@bflad
resource/aws_redshift_snapshot_copy_grant: Finish import implementation
6de2146 
Reference: #10350

Output from acceptance testing:

```
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (18.21s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (42.92s)
```
bflad added a commit that referenced this pull request Apr 7, 2020
@bflad
Update CHANGELOG for #10350
3fc8669
@bflad bflad merged commit f488c60 into hashicorp:master Apr 7, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

twitty-rival pushed a commit to twitty-rival/terraform-provider-aws that referenced this pull request May 6, 2020
@bflad @twitty-rival
resource/aws_redshift_snapshot_copy_grant: Finish import implementation
2959be6 
Reference: hashicorp#10350

Output from acceptance testing:

```
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (18.21s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (42.92s)
```
twitty-rival pushed a commit to twitty-rival/terraform-provider-aws that referenced this pull request May 6, 2020
@bflad @twitty-rival
Update CHANGELOG for hashicorp#10350
64e7b14
@ghost
Copy link

ghost commented May 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad left review comments

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.57.0
Development

Successfully merging this pull request may close these issues.
2 participants
@f0rk @bflad