Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module hashicorp/aws-sdk-go-base to v0.4.0 #10379

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 3, 2019

This PR contains the following updates:

Package Type Update Change
github.com/hashicorp/aws-sdk-go-base require minor v0.3.0 -> v0.4.0

Release Notes

hashicorp/aws-sdk-go-base

v0.4.0

Compare Source

BUG FIXES

  • awsauth: fixed credentials retrieval, validation, and error handling

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from a team October 3, 2019 22:48
@renovate renovate bot added the dependencies Used to indicate dependency changes. label Oct 3, 2019
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Oct 3, 2019
@aeschright aeschright added this to the v2.32.0 milestone Oct 3, 2019
@aeschright
Copy link
Contributor

aeschright commented Oct 4, 2019

I'm checking over bugs reported on assume role issues.

Fixed:
#200
#5251
#5592
#6424
#10066

@YakDriver
Copy link
Member

This is a great move forward and building block for knocking out a few more issues.

@aeschright aeschright merged commit e8adbbf into master Oct 8, 2019
@aeschright aeschright deleted the renovate/github.com-hashicorp-aws-sdk-go-base-0.x branch October 8, 2019 18:01
aeschright added a commit that referenced this pull request Oct 8, 2019
@YakDriver
Copy link
Member

🎉

@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@scalp42
Copy link
Contributor

scalp42 commented Oct 18, 2019

We just tested with 2.33.0 and it's still broken for us unfortunately:

$> AWS_SDK_LOAD_CONFIG=1 AWS_REGION=us-west-2 terraform plan                                                                                             

Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

data.terraform_remote_state.shared_us_west_2_vpc_shared: Refreshing state...
data.terraform_remote_state.dev_us_west_2_vpc_dev: Refreshing state...
data.terraform_remote_state.prod_global: Refreshing state...
data.terraform_remote_state.prod_us_west_2: Refreshing state...
data.terraform_remote_state.shared_us_west_2: Refreshing state...
data.terraform_remote_state.global: Refreshing state...

Error: Error refreshing state: 1 error occurred:
	* provider.aws.prod-us-west-2: Error creating AWS session: CredentialRequiresARNError: credential type source_profile requires role_arn, profile bridge
provider "aws" {
  alias  = "prod-us-west-2"
  region = "us-west-2"

  version             = "= 2.33.0"
  profile             = "prod"
  allowed_account_ids = ["123456789"]
}
$> cat ~/.aws/config
[profile prod]
role_arn = arn:aws:iam::123456789:role/admin
role_session_name = anthony-prod
source_profile = bridge
region = us-west-2

[profile bridge]
source_profile = bridge
region = us-west-2
$> terraform --version                                                                                                                                   
Terraform v0.11.14
+ provider.aws v2.33.0

Your version of Terraform is out of date! The latest version
is 0.12.11. You can update by downloading from www.terraform.io/downloads.html

@lorengordon
Copy link
Contributor

@scalp42 why do you have source_profile = bridge in both the bridge profile and the prod profile?

@scalp42
Copy link
Contributor

scalp42 commented Oct 21, 2019

@lorengordon you're indeed correct sir, see #9999 (comment)

@lorengordon
Copy link
Contributor

Hot diggity! 🎉

@aeschright
Copy link
Contributor

Hi folks, I'm glad to see that's working ok after all! Just a reminder that if you do encounter a regression or anything that still doesn't work, please open a new issue instead of commenting on the closed one so I can make sure we address it. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants