resource/aws_gamelift_fleet: Increase default deletion timeout to 20 minutes, add missing timeouts documentation #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minutes, add missing timeouts documentation Reference: https://docs.aws.amazon.com/gamelift/latest/developerguide/fleets-editing.html Our daily acceptance testing is often failing due to the current default deletion timeout of 5 minutes: ``` --- FAIL: TestAccAWSGameliftFleet_basic (1350.58s) testing.go:630: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 5m0s) ``` The GameLift documentation does not provide too much guidance on the expected deletion time, but increasing this to 20 minutes to match typical EC2 instance deletion maximums should help. Output from acceptance testing: ``` --- PASS: TestAccAWSGameliftFleet_basic (1494.07s) --- PASS: TestAccAWSGameliftFleet_allFields (1535.56s) ```
bflad
added
bug
ghost
added
size/XS
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: https://docs.aws.amazon.com/gamelift/latest/developerguide/fleets-editing.html
Release note for CHANGELOG:
Our daily acceptance testing is often failing due to the current default deletion timeout of 5 minutes:
The GameLift documentation does not provide too much guidance on the expected deletion time, but increasing this to 20 minutes to match typical EC2 instance deletion maximums should help.
Output from acceptance testing: