Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag Support to Storage Gateway SMB File Share Resource #10620

Merged
merged 10 commits into from
Oct 30, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7826

Release note for CHANGELOG:

- resource/resource_aws_storagegateway_smb_file_share: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory'

=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (873.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	879.585s

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_Tags'

=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (1789.64s)
PASS

...

@DrFaust92 DrFaust92 requested a review from a team October 24, 2019 14:08
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 24, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 30, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (249.51s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (277.31s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (306.82s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (309.64s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (311.39s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (316.31s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (348.66s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (373.25s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (706.14s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (816.91s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (839.35s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (219.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (237.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (254.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (283.71s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (288.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (291.01s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (292.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (320.15s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (339.62s)

@bflad bflad added this to the v2.34.0 milestone Oct 30, 2019
@bflad bflad merged commit ea9edf5 into hashicorp:master Oct 30, 2019
bflad added a commit that referenced this pull request Oct 30, 2019
@bflad
Copy link
Contributor

bflad commented Oct 31, 2019

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@DrFaust92 DrFaust92 deleted the storage-gateway-smb-tags branch November 2, 2019 06:39
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants