Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_network_interface: Add the mac_address attribute #10633

Merged
merged 2 commits into from
Jan 18, 2020

Conversation

notkmhn
Copy link
Contributor

@notkmhn notkmhn commented Oct 25, 2019

Summary

Adds a mac_address attribute to the aws_network_interface resource, which is already exposed by the aws_network_interface data source. This is useful when used in conjunction with cloud-init in cases when there is a need to identify an attached interface by its MAC address. For example, when using netplan to add specific routes to a network interface on EC2 instance creation.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6863

Release note for CHANGELOG:

resource/aws_network_interface: Add `mac_address` attribute.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run "TestAccAWSENI_.*"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run "TestAccAWSENI_.*" -timeout 120m
=== RUN   TestAccAWSENI_basic
=== PAUSE TestAccAWSENI_basic
=== RUN   TestAccAWSENI_disappears
=== PAUSE TestAccAWSENI_disappears
=== RUN   TestAccAWSENI_updatedDescription
=== PAUSE TestAccAWSENI_updatedDescription
=== RUN   TestAccAWSENI_attached
=== PAUSE TestAccAWSENI_attached
=== RUN   TestAccAWSENI_ignoreExternalAttachment
=== PAUSE TestAccAWSENI_ignoreExternalAttachment
=== RUN   TestAccAWSENI_sourceDestCheck
=== PAUSE TestAccAWSENI_sourceDestCheck
=== RUN   TestAccAWSENI_computedIPs
=== PAUSE TestAccAWSENI_computedIPs
=== RUN   TestAccAWSENI_PrivateIpsCount
=== PAUSE TestAccAWSENI_PrivateIpsCount
=== CONT  TestAccAWSENI_basic
=== CONT  TestAccAWSENI_sourceDestCheck
=== CONT  TestAccAWSENI_computedIPs
=== CONT  TestAccAWSENI_PrivateIpsCount
=== CONT  TestAccAWSENI_attached
=== CONT  TestAccAWSENI_updatedDescription
=== CONT  TestAccAWSENI_disappears
=== CONT  TestAccAWSENI_ignoreExternalAttachment
--- PASS: TestAccAWSENI_computedIPs (63.40s)
--- PASS: TestAccAWSENI_sourceDestCheck (64.07s)
--- PASS: TestAccAWSENI_disappears (64.33s)
--- PASS: TestAccAWSENI_basic (70.01s)
--- PASS: TestAccAWSENI_updatedDescription (115.33s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (146.42s)
--- PASS: TestAccAWSENI_PrivateIpsCount (178.06s)
--- PASS: TestAccAWSENI_attached (292.23s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       292.251s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 25, 2019
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 25, 2019
@notkmhn notkmhn marked this pull request as ready for review October 25, 2019 10:11
@notkmhn notkmhn requested a review from a team October 25, 2019 10:11
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KhaledNassar 🚀

Output from acceptance testing:

--- PASS: TestAccAWSENI_disappears (13.85s)
--- PASS: TestAccAWSENI_sourceDestCheck (14.29s)
--- PASS: TestAccAWSENI_computedIPs (15.60s)
--- PASS: TestAccAWSENI_basic (16.20s)
--- PASS: TestAccAWSENI_updatedDescription (23.13s)
--- PASS: TestAccAWSENI_PrivateIpsCount (35.54s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (194.63s)
--- PASS: TestAccAWSENI_attached (361.15s)

@bflad bflad added this to the v2.46.0 milestone Jan 18, 2020
@bflad bflad merged commit 7356b30 into hashicorp:master Jan 18, 2020
bflad added a commit that referenced this pull request Jan 18, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants