Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_batch_compute_environment to support name prefix #10682

Merged
merged 3 commits into from
Jan 3, 2020
Merged

aws_batch_compute_environment to support name prefix #10682

merged 3 commits into from
Jan 3, 2020

Conversation

marcinwyszynski
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3207

Release note for CHANGELOG:

Adds `compute_environment_name_prefix` argument to `aws_batch_compute_environment` to allow cleanly replacing environments using `lifecycle.create_before_destroy = true`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
...

@marcinwyszynski marcinwyszynski requested a review from a team October 30, 2019 15:59
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 30, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 30, 2019
@theophilechevalier theophilechevalier mentioned this pull request Dec 2, 2019
Closed
@kislyuk
Copy link

kislyuk commented Dec 4, 2019

@shibataka000 can you please take a look at this? It helps fix a major defect in the Batch module.

@shibataka000
Copy link
Contributor

@kislyuk I'm not a terraform provider team members. Please wait that one of them will review this PR.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 3, 2020
@bflad bflad added this to the v2.44.0 milestone Jan 3, 2020
@bflad bflad self-assigned this Jan 3, 2020
bflad
bflad approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcinwyszynski 🚀

Output from acceptance testing:

--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (57.10s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (15.41s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (44.79s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (51.98s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (17.64s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (49.81s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (42.57s)
--- PASS: TestAccAWSBatchComputeEnvironment_createWithNamePrefix (59.94s)
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (49.67s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (63.90s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (63.52s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (73.90s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (61.55s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (65.60s)

@bflad bflad merged commit d5c8c1e into hashicorp:master Jan 3, 2020
bflad added a commit that referenced this pull request Jan 3, 2020
@bflad
Update CHANGELOG for #10682
ba68c30
@marcinwyszynski marcinwyszynski deleted the feature/compute_environment_name_prefix branch January 4, 2020 23:43
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@thomas-maschler thomas-maschler mentioned this pull request Jan 27, 2020
Closed
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.44.0
Development

Successfully merging this pull request may close these issues.

name prefix request to aws_batch_compute_environment
4 participants
@marcinwyszynski @kislyuk @shibataka000 @bflad