r/aws_cloudwatch_log_group: Refactor tagging logic to keyvaluetags package

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchLogGroup_'

=== RUN   TestAccAWSCloudWatchLogGroup_basic
=== PAUSE TestAccAWSCloudWatchLogGroup_basic
=== CONT  TestAccAWSCloudWatchLogGroup_basic
--- PASS: TestAccAWSCloudWatchLogGroup_basic (49.41s)
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (53.47s)
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix_retention
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (102.93s)
=== RUN   TestAccAWSCloudWatchLogGroup_generatedName
=== PAUSE TestAccAWSCloudWatchLogGroup_generatedName
=== CONT  TestAccAWSCloudWatchLogGroup_generatedName
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (51.20s)
=== RUN   TestAccAWSCloudWatchLogGroup_retentionPolicy
=== PAUSE TestAccAWSCloudWatchLogGroup_retentionPolicy
=== CONT  TestAccAWSCloudWatchLogGroup_retentionPolicy
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (91.92s)
=== RUN   TestAccAWSCloudWatchLogGroup_multiple
=== PAUSE TestAccAWSCloudWatchLogGroup_multiple
=== CONT  TestAccAWSCloudWatchLogGroup_multiple
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (60.42s)
=== RUN   TestAccAWSCloudWatchLogGroup_disappears
=== PAUSE TestAccAWSCloudWatchLogGroup_disappears
=== CONT  TestAccAWSCloudWatchLogGroup_disappears
--- PASS: TestAccAWSCloudWatchLogGroup_disappears (38.91s)
=== RUN   TestAccAWSCloudWatchLogGroup_tagging
=== PAUSE TestAccAWSCloudWatchLogGroup_tagging
=== CONT  TestAccAWSCloudWatchLogGroup_tagging
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (179.97s)
=== RUN   TestAccAWSCloudWatchLogGroup_kmsKey
=== PAUSE TestAccAWSCloudWatchLogGroup_kmsKey
=== CONT  TestAccAWSCloudWatchLogGroup_kmsKey
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (192.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	844.192s

...

[bflad]

LGTM, thanks @DrFaust92 🚀 Marked as an enhancement and will note in the CHANGELOG this resource will now support tagging on creation (couldn't find a relevant issue number for this)

Output from AWS Commercial:

--- PASS: TestAccAWSCloudWatchLogGroup_disappears (7.38s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (9.73s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (12.21s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (14.72s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (15.03s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (15.13s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (17.91s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (29.56s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (36.66s)

Output from AWS GovCloud (US):

--- PASS: TestAccAWSCloudWatchLogGroup_disappears (7.85s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (9.39s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (10.20s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (12.38s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (12.57s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (12.59s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (16.86s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (19.05s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (40.68s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!