Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_efs_file_system: Support 7-day lifecycle management policy #10825

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10774.

Release note for CHANGELOG:

resource/aws_efs_file_system: Add `AFTER_7_DAYS` as a valid `lifecycle_policy.transition_to_ia` attribute value

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEFSFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_ -timeout 120m
=== RUN   TestAccAWSEFSFileSystem_basic
=== PAUSE TestAccAWSEFSFileSystem_basic
=== RUN   TestAccAWSEFSFileSystem_pagedTags
=== PAUSE TestAccAWSEFSFileSystem_pagedTags
=== RUN   TestAccAWSEFSFileSystem_kmsKey
=== PAUSE TestAccAWSEFSFileSystem_kmsKey
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== PAUSE TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== PAUSE TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
=== PAUSE TestAccAWSEFSFileSystem_ThroughputMode
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== CONT  TestAccAWSEFSFileSystem_basic
=== CONT  TestAccAWSEFSFileSystem_ThroughputMode
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy
=== CONT  TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== CONT  TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== CONT  TestAccAWSEFSFileSystem_kmsKey
=== CONT  TestAccAWSEFSFileSystem_pagedTags
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (35.26s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (42.66s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (64.83s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (69.56s)
--- PASS: TestAccAWSEFSFileSystem_basic (82.03s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (84.91s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (92.08s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (99.39s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (154.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	154.453s

@ewbankkit ewbankkit requested a review from a team November 10, 2019 01:44
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. labels Nov 10, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2019
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (24.74s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (66.07s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (72.03s)
--- PASS: TestAccAWSEFSFileSystem_basic (81.67s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (87.24s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (89.03s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (91.89s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (97.24s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (133.01s)

@bflad bflad merged commit 1bde9db into hashicorp:master Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
@ewbankkit ewbankkit deleted the issue-10774 branch November 18, 2019 08:27
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Elastic File System Infrequent Access Now Supports a 7-day Lifecycle Management Policy
2 participants