Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_eks_node_group #10916

Merged
merged 1 commit into from
Nov 18, 2019
Merged

New Resource: aws_eks_node_group #10916

merged 1 commit into from
Nov 18, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 18, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10915

Release note for CHANGELOG:

* **New Resource:** `aws_eks_node_group`

Output from acceptance testing:

--- PASS: TestAccAWSEksNodeGroup_AmiType (1541.19s)
--- PASS: TestAccAWSEksNodeGroup_basic (1592.90s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1474.40s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1509.60s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1718.96s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1674.47s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (1473.09s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1572.12s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1579.61s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1695.85s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1644.41s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1622.42s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1614.55s)
--- PASS: TestAccAWSEksNodeGroup_Version (1721.66s)

@bflad
New Resource: aws_eks_node_group
790ce54 
Output from acceptance testing:

```
--- PASS: TestAccAWSEksNodeGroup_AmiType (1541.19s)
--- PASS: TestAccAWSEksNodeGroup_basic (1592.90s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1474.40s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1509.60s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1718.96s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1674.47s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (1473.09s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1572.12s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1579.61s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1695.85s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1644.41s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1622.42s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1614.55s)
--- PASS: TestAccAWSEksNodeGroup_Version (1721.66s)
```
@bflad bflad added new-resource Introduces a new resource. service/eks Issues and PRs that pertain to the eks service. labels Nov 18, 2019
@bflad bflad added this to the v2.38.0 milestone Nov 18, 2019
@bflad bflad requested a review from a team November 18, 2019 20:37
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 18, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 18, 2019
@bflad
Copy link
Contributor Author

bflad commented Nov 18, 2019

These code changes were previously reviewed and CI is passing, merging!

@bflad bflad merged commit 71a088d into master Nov 18, 2019
@bflad bflad deleted the f-aws_eks_node_group branch November 18, 2019 20:50
bflad added a commit that referenced this pull request Nov 18, 2019
@bflad
Update CHANGELOG for #10916
cef67de
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.38.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Support Amazon EKS Managed Node Groups
1 participant
@bflad