Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate batch_compute_environment when updating launch_template #11057

Conversation

theophilechevalier
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11012
Forces to recreate a new batch_compute_environment when the associated launch_template is updated.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate'

=== RUN   TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (135.79s)
PASS
...

Addresses hashicorp#11012. Forces to recreate a new batch_compute_environment
when the associated launch_template is updated.
@theophilechevalier theophilechevalier requested a review from a team November 28, 2019 16:24
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2019
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2019
@gdavison gdavison self-assigned this Nov 28, 2019
@gdavison gdavison added the bug Addresses a defect in current functionality. label Nov 28, 2019
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @theophilechevalier 🚀

@gdavison gdavison removed their assignment Nov 28, 2019
@gdavison gdavison added this to the v2.41.0 milestone Nov 28, 2019
@gdavison gdavison merged commit f5fb1f2 into hashicorp:master Nov 28, 2019
gdavison added a commit that referenced this pull request Nov 28, 2019
@ghost
Copy link

ghost commented Dec 4, 2019

This has been released in version 2.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_compute_environment: launch_template update should destroy and recreate CE
2 participants