Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS Cluster Endpoint tagging support #11074

Merged
merged 1 commit into from
Jan 17, 2020
Merged

RDS Cluster Endpoint tagging support #11074

merged 1 commit into from
Jan 17, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 30, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11043

Release note for CHANGELOG:

resource/rds_cluster_endpoint: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRDSClusterEndpoint_'
=== RUN   TestAccAWSRDSClusterEndpoint_basic
=== PAUSE TestAccAWSRDSClusterEndpoint_basic
=== CONT  TestAccAWSRDSClusterEndpoint_basic
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1638.48s)
=== RUN   TestAccAWSRDSClusterEndpoint_tags
=== PAUSE TestAccAWSRDSClusterEndpoint_tags
=== CONT  TestAccAWSRDSClusterEndpoint_tags
--- PASS: TestAccAWSRDSClusterEndpoint_tags (2120.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2148.207s

...

@DrFaust92 DrFaust92 requested a review from a team November 30, 2019 15:08
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 30, 2019
@DrFaust92 DrFaust92 changed the title [WIP]RDS Cluster Endpoint tagging support RDS Cluster Endpoint tagging support Nov 30, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 17, 2020
bflad
bflad approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation (will handle on merge), but otherwise LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRDSClusterEndpoint_tags (1065.58s)
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1149.82s)

@bflad bflad merged commit 1c128d3 into hashicorp:master Jan 17, 2020
bflad added a commit that referenced this pull request Jan 17, 2020
@bflad
Update CHANGELOG for #11074
b2cfd0f
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.46.0
Development

Successfully merging this pull request may close these issues.

RDS Aurora cluster endpoint tagging
2 participants
@DrFaust92 @bflad