Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v1.1.0 of github.com/jen20/awspolicyequivalence #11107

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Update to v1.1.0 of github.com/jen20/awspolicyequivalence #11107

merged 1 commit into from
Dec 5, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Dec 3, 2019 •
edited by bflad
Loading

This brings in the fix from @ewbankkit for a panic in the case of an incorrect type assertion against nil.

Closes #10135.
Closes #10528.

Fix a panic during plan for IAM policies with a nil `Resources` stanza.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@jen20 jen20 requested a review from a team December 3, 2019 16:12
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Dec 3, 2019
@bflad
Copy link
Contributor

bflad commented Dec 3, 2019

Hey @jen20 👋 Thanks for submitting this. Did you happen to run go mod tidy? The automated Renovate pull request for this upgrade removes the old checksum entries: #11108

@jen20
Update to v1.1.0 of github.com/jen20/awspolicyequivalence
de06013 
This brings in the fix from @ewbankkit for a panic in the case of an
incorrect type assertion against nil.

Fixes #10135.
Fixes #10528.
@jen20
Copy link
Contributor Author

jen20 commented Dec 3, 2019

I've pushed a new commit with go mod tidy applied.

@bflad bflad mentioned this pull request Dec 5, 2019
Closed
1 task
@bflad bflad added this to the v2.42.0 milestone Dec 5, 2019
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. provider Pertains to the provider itself, rather than any interaction with AWS. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2019
bflad
bflad approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream library has extensive unit testing covering its functionality against regressions and includes additional testing for this panic scenario, which passes as expected. Thanks so much for this fix @ewbankkit and @jen20 🚀

@bflad bflad merged commit 88ccc41 into hashicorp:master Dec 5, 2019
bflad added a commit that referenced this pull request Dec 5, 2019
@bflad
Update CHANGELOG for #11107
ecdb702
bflad added a commit that referenced this pull request Dec 5, 2019
@bflad
tests/resource/aws_iam_role_policy: Add covering acceptance testing f…
aa3c090 
…or invalid Resource declaration

Reference: #11107

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (13.91s)
```
@jen20 jen20 deleted the jen20/update-awspolicyequivalence branch December 5, 2019 13:55
@ghost
Copy link

ghost commented Dec 13, 2019

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.42.0
2 participants
@jen20 @bflad