Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_eks_fargate_profile #11111

Merged
merged 1 commit into from
Dec 3, 2019
Merged

New Resource: aws_eks_fargate_profile #11111

merged 1 commit into from
Dec 3, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 3, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11109
Closes #11110

Release note for CHANGELOG:

* **New Resource:** `aws_eks_fargate_profile`

Output from acceptance testing:

--- PASS: TestAccAWSEksFargateProfile_Selector_Labels (1511.68s)
--- PASS: TestAccAWSEksFargateProfile_basic (1599.46s)
--- PASS: TestAccAWSEksFargateProfile_disappears (1663.86s)
--- PASS: TestAccAWSEksFargateProfile_Tags (1810.36s)

@bflad bflad added new-resource Introduces a new resource. service/eks Issues and PRs that pertain to the eks service. labels Dec 3, 2019
@bflad bflad added this to the v2.41.0 milestone Dec 3, 2019
@bflad bflad requested a review from a team December 3, 2019 17:34
@bflad bflad self-assigned this Dec 3, 2019
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 3, 2019
@bflad
New Resource: aws_eks_fargate_profile
31f9e91 
Output from acceptance testing in AWS Commercial (us-east-2):

```
--- PASS: TestAccAWSEksFargateProfile_basic (1487.63s)
--- PASS: TestAccAWSEksFargateProfile_disappears (1496.90s)
--- PASS: TestAccAWSEksFargateProfile_Selector_Labels (1482.71s)
--- PASS: TestAccAWSEksFargateProfile_Tags (1420.50s)
```
@bflad bflad force-pushed the f-aws_eks_fargate_profile branch from e4f7fa8 to 31f9e91 Compare December 3, 2019 21:21
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 3, 2019
@bflad
Copy link
Contributor Author

bflad commented Dec 3, 2019

This code was previously reviewed, CI and acceptance testing is passing, merging. 👍

@bflad bflad merged commit fe0f424 into master Dec 3, 2019
@bflad bflad deleted the f-aws_eks_fargate_profile branch December 3, 2019 23:42
bflad added a commit that referenced this pull request Dec 3, 2019
@bflad
Update CHANGELOG for #11111
79f0257
@ghost
Copy link

ghost commented Dec 4, 2019

This has been released in version 2.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.41.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Amazon EKS on AWS Fargate Support Fargate Profiles for AWS EKS
1 participant
@bflad