Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_lambda_function_event_invoke_config #11165

Merged
merged 1 commit into from
Dec 18, 2019
Merged

New Resource: aws_lambda_function_event_invoke_config #11165

merged 1 commit into from
Dec 18, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11087

Release note for CHANGELOG:

* **New Resource:** `aws_lambda_function_event_invoke_config`

Output from acceptance testing:

--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (39.02s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (41.57s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (48.59s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (67.00s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (68.94s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (70.85s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (75.07s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (92.63s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (101.05s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (108.37s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (111.47s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (118.33s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (121.72s)

@bflad bflad added new-resource Introduces a new resource. service/lambda Issues and PRs that pertain to the lambda service. labels Dec 6, 2019
@bflad bflad requested a review from a team December 6, 2019 03:08
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 6, 2019
@bflad bflad mentioned this pull request Dec 6, 2019
Closed
@bflad bflad force-pushed the f-aws_lambda_function_event_invoke_config branch from 6bf4ac0 to 7baa567 Compare December 6, 2019 04:44
@bflad
New Resource: aws_lambda_function_event_invoke_config
bbfd47f 
Reference: #11087

Output from acceptance testing:

```
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (39.02s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (41.57s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (48.59s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (67.00s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (68.94s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (70.85s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (75.07s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (92.63s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (101.05s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (108.37s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (111.47s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (118.33s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (121.72s)
```
@bflad bflad force-pushed the f-aws_lambda_function_event_invoke_config branch from 7baa567 to bbfd47f Compare December 6, 2019 13:35
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2019
gdavison
gdavison approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (28.91s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (29.38s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (38.61s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (39.16s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (39.17s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (39.50s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (40.13s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (40.33s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (46.99s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (49.26s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (54.43s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (63.78s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (64.50s)

@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
@bflad bflad merged commit 6526c89 into master Dec 18, 2019
@bflad bflad deleted the f-aws_lambda_function_event_invoke_config branch December 18, 2019 01:52
bflad added a commit that referenced this pull request Dec 18, 2019
@bflad
Update CHANGELOG for #11165
c0ed331
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.43.0
Development

Successfully merging this pull request may close these issues.

Add support for Lambda Destinations for Asynchronous Invocations
2 participants
@bflad @gdavison