Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CONTAINER_ARM as valid environment type #11206

Merged
merged 4 commits into from
Dec 10, 2019
Merged

add CONTAINER_ARM as valid environment type #11206

merged 4 commits into from
Dec 10, 2019

Conversation

kabej
Copy link
Contributor

@kabej kabej commented Dec 9, 2019

Fix for #11204

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/codebuild Issues and PRs that pertain to the codebuild service. labels Dec 9, 2019
@kabej kabej marked this pull request as ready for review December 9, 2019 14:42
@kabej kabej requested a review from a team December 9, 2019 14:42
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kabej 👋 Thank you for submitting this. Please see the below feedback and let us know if you have any questions or do not have time to implement the items. 👍

aws/resource_aws_codebuild_project.go Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2019
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 9, 2019
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 9, 2019
@kabej kabej requested a review from bflad December 9, 2019 16:51
aws/resource_aws_codebuild_project_test.go Outdated Show resolved Hide resolved
aws/resource_aws_codebuild_project_test.go Show resolved Hide resolved
@kabej kabej requested a review from bflad December 10, 2019 08:18
@bflad bflad added this to the v2.42.0 milestone Dec 10, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kabej 🚀

Output from acceptance testing (will remove failing TestCheckResourceAttr() from TestAccAWSCodeBuildProject_ARMContainer on merge):

--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (35.18s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (63.19s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (63.34s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (68.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (56.84s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (11.66s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (78.82s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (78.93s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (45.62s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (81.69s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (86.06s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (89.83s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (91.38s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (93.39s)
--- FAIL: TestAccAWSCodeBuildProject_ARMContainer (42.52s)
    testing.go:635: Step 0 error: Check failed: Check 3/8 error: aws_codebuild_project.test: Attribute 'environment.2306861956.compute_type' not found
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (48.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (60.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (125.31s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (45.70s)
--- PASS: TestAccAWSCodeBuildProject_Tags (81.85s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (75.75s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (66.93s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (77.10s)
--- PASS: TestAccAWSCodeBuildProject_basic (166.17s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (91.77s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (82.44s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (49.91s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (62.48s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (60.80s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (42.36s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (74.98s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (39.93s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (45.97s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (33.83s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (36.97s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (210.63s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (50.36s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (218.97s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (138.94s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (47.72s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (87.84s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (227.59s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (84.66s)
--- PASS: TestAccAWSCodeBuildProject_Description (253.03s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (248.65s)
--- PASS: TestAccAWSCodeBuildProject_Cache (345.71s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (379.34s)

@bflad bflad merged commit 6a3f383 into hashicorp:master Dec 10, 2019
bflad added a commit that referenced this pull request Dec 10, 2019
@ghost
Copy link

ghost commented Dec 13, 2019

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 13, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants