-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CONTAINER_ARM as valid environment type #11206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kabej 👋 Thank you for submitting this. Please see the below feedback and let us know if you have any questions or do not have time to implement the items. 👍
Co-Authored-By: Brian Flad <bflad417@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kabej 🚀
Output from acceptance testing (will remove failing TestCheckResourceAttr()
from TestAccAWSCodeBuildProject_ARMContainer
on merge):
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (35.18s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (63.19s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (63.34s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (68.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (56.84s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (11.66s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (78.82s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (78.93s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (45.62s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (81.69s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (86.06s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (89.83s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (91.38s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (93.39s)
--- FAIL: TestAccAWSCodeBuildProject_ARMContainer (42.52s)
testing.go:635: Step 0 error: Check failed: Check 3/8 error: aws_codebuild_project.test: Attribute 'environment.2306861956.compute_type' not found
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (48.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (60.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (125.31s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (45.70s)
--- PASS: TestAccAWSCodeBuildProject_Tags (81.85s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (75.75s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (66.93s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (77.10s)
--- PASS: TestAccAWSCodeBuildProject_basic (166.17s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (91.77s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (82.44s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (49.91s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (62.48s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (60.80s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (42.36s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (74.98s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (39.93s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (45.97s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (33.83s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (36.97s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (210.63s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (50.36s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (218.97s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (138.94s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (47.72s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (87.84s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (227.59s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (84.66s)
--- PASS: TestAccAWSCodeBuildProject_Description (253.03s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (248.65s)
--- PASS: TestAccAWSCodeBuildProject_Cache (345.71s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (379.34s)
This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fix for #11204