Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue 11182 #11253

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Fixes issue 11182 #11253

merged 1 commit into from
Dec 18, 2019

Conversation

zsiddique
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11182

Release note for CHANGELOG:

None

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@zsiddique zsiddique requested a review from a team December 11, 2019 19:44
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. labels Dec 11, 2019
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2019
@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
bflad
bflad approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for fixing this @zsiddique 🚀 I was able to confirm that setting 0 before this change caused an error (by slightly adjusting an existing acceptance test):

--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_update (182.73s)
    testing.go:640: Step 1 error: Check failed: Check 7/8 error: aws_globalaccelerator_endpoint_group.example: Attribute 'traffic_dial_percentage' expected "0", got "100"

Output from acceptance testing after change:

--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (162.47s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (200.66s)

@bflad bflad merged commit 70aefd0 into hashicorp:master Dec 18, 2019
bflad added a commit that referenced this pull request Dec 18, 2019
@bflad
Update CHANGELOG for #11253
4128676
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.43.0
Development

Successfully merging this pull request may close these issues.

aws_globalaccelerator_endpoint_group traffic_dial_percentage cannot be set to 0
2 participants
@zsiddique @bflad