Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent error when updating Capacity Providers on ECS Cluster #11310

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

gdavison
Copy link
Contributor

Fixes an intermittent failure when updating the capacity providers on an ECS cluster when the cluster status is not ACTIVE.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11285

Release note for CHANGELOG:

resource/aws_ecs_cluster: fixes intermittent failures on update when cluster dependencies are updating.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsCluster_'

--- PASS: TestAccAWSEcsCluster_disappears (14.50s)
--- PASS: TestAccAWSEcsCluster_basic (18.39s)
--- PASS: TestAccAWSEcsCluster_containerInsights (39.06s)
--- PASS: TestAccAWSEcsCluster_Tags (40.84s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (47.33s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (51.29s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (86.14s)

@gdavison gdavison requested a review from a team December 16, 2019 18:41
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. labels Dec 16, 2019
@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Dec 17, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

--- PASS: TestAccAWSEcsCluster_disappears (12.78s)
--- PASS: TestAccAWSEcsCluster_basic (16.07s)
--- PASS: TestAccAWSEcsCluster_containerInsights (33.87s)
--- PASS: TestAccAWSEcsCluster_Tags (35.56s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (43.38s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (63.04s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (77.35s)

@gdavison gdavison merged commit 79700fc into master Dec 18, 2019
@gdavison gdavison deleted the b-ecs-update-status branch December 18, 2019 00:01
gdavison added a commit that referenced this pull request Dec 18, 2019
@gdavison gdavison added this to the v2.43.0 milestone Dec 18, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent error when updating Capacity Providers on ECS Cluster
3 participants