Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cloudwatch event rule resource to use keyvaluetags + refactor tests #11346

Merged
merged 9 commits into from
Jan 3, 2020
Merged

Refactor cloudwatch event rule resource to use keyvaluetags + refactor tests #11346

merged 9 commits into from
Jan 3, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 18, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688, Closes #10346

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventRule_'
--- PASS: TestAccAWSCloudWatchEventRule_basic (75.92s)
--- PASS: TestAccAWSCloudWatchEventRule_role (63.59s)
--- PASS: TestAccAWSCloudWatchEventRule_description (79.48s)
--- PASS: TestAccAWSCloudWatchEventRule_pattern (87.45s)
--- PASS: TestAccAWSCloudWatchEventRule_prefix (39.02s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (108.63s)
--- PASS: TestAccAWSCloudWatchEventRule_enable (119.40s)
...

@DrFaust92 DrFaust92 requested a review from a team December 18, 2019 14:59
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 18, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2019
@DrFaust92 DrFaust92 changed the title [WIP]Refactor cloudwatch resources to use keyvaluetags [WIP]Refactor cloudwatch resources to use keyvaluetags + refactor tests Dec 19, 2019
@DrFaust92 DrFaust92 changed the title [WIP]Refactor cloudwatch resources to use keyvaluetags + refactor tests Refactor cloudwatch event rule resource to use keyvaluetags + refactor tests Dec 19, 2019
bflad
bflad approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudWatchEventRule_prefix (8.59s)
--- PASS: TestAccAWSCloudWatchEventRule_description (14.25s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (14.53s)
--- PASS: TestAccAWSCloudWatchEventRule_pattern (14.65s)
--- PASS: TestAccAWSCloudWatchEventRule_enable (18.67s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (18.90s)
--- PASS: TestAccAWSCloudWatchEventRule_role (26.33s)

aws/resource_aws_cloudwatch_event_rule.go
return nil
}

func resourceAwsCloudWatchEventRuleUpdate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).cloudwatcheventsconn

if d.HasChange("is_enabled") && d.Get("is_enabled").(bool) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to understand how removing this code was not breaking is_enabled functionality 😅 and my guess is that when the original implementation was done years ago, the PutRule API State parameter was not properly disabling/enabling rules.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was scratching my head for a while after seeing this

@bflad bflad added this to the v2.44.0 milestone Jan 3, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 3, 2020
@bflad bflad merged commit d2ca27f into hashicorp:master Jan 3, 2020
bflad added a commit that referenced this pull request Jan 3, 2020
@bflad
Update CHANGELOG for #11346
29e0a87
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.44.0
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_event_rule is_enabled flag is not working
2 participants
@DrFaust92 @bflad