-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_kinesis_stream: Add support for encryption #1139
Conversation
Any update on this? |
+1, any updates? |
Hey @stack72 Are you still having issues with the StopEncryption thing? Thanks! |
@Ninir if you want, we can jump on a call at some point and i can show you the issues I am having with this :) |
Hi Paul! Sure, if I can be of any help... 😄 🤷♂️ ! |
Bump on this one! |
0d4f446
to
10e5ba6
Compare
@stack72 Do you want to hangout / Skype / other? :) |
Hi @Ninir
This is now ready for review - I worked through it with @tombuildsstuff on
Saturday
Paul
…On Mon, 11 Sep 2017 at 15:41, Gauthier Wallet ***@***.***> wrote:
@stack72 <https://github.com/stack72> Do you want to hangout / Skype /
other? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN57_khaZdIIv6Rnv3t6mMZKqUIJ6z6ks5shSpkgaJpZM4OWeDd>
.
|
Thanks for that @stack72 ! (Could you indicate me a way to contact you for a quick chat? Gitter / other? thanks!) |
@Ninir i can log into gitter - also, the acceptance tests for this were run via teamcity |
Any updates on when this might go through? |
10e5ba6
to
fc68ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I just fixed a wrong field name in a separate commit, otherwise this LGTM, merging... 🚀
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes: #1109
Got an issue with StopEncryption - working on this atm