Allows enabling support of tag policies #11535
Conversation
ghost
added
size/S
bflad
added
enhancement
There was a problem hiding this comment.
Hi @nikolaifa 👋 Thank you for submitting this. Please see the below feedback items and let us know if you have any questions or do not have time to implement them.
bflad
added
the
waiting-response
ghost
added
size/XS
bflad
removed
the
waiting-response
There was a problem hiding this comment.
LGTM, thanks @nikolaifa 🚀 Will fix documentation on merge.
Output from acceptance testing:
--- PASS: TestAccAWSOrganizations/Organization (189.32s)
--- PASS: TestAccAWSOrganizations/Organization/FeatureSet (16.63s)
--- PASS: TestAccAWSOrganizations/Organization/DataSource (31.42s)
--- PASS: TestAccAWSOrganizations/Organization/basic (19.31s)
--- PASS: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (39.67s)
--- PASS: TestAccAWSOrganizations/Organization/EnabledPolicyTypes (82.29s)
| @@ -28,7 +28,7 @@ resource "aws_organizations_organization" "org" { | |||
| The following arguments are supported: | |||
|
|
|||
| * `aws_service_access_principals` - (Optional) List of AWS service principal names for which you want to enable integration with your organization. This is typically in the form of a URL, such as service-abbreviation.amazonaws.com. Organization must have `feature_set` set to `ALL`. For additional information, see the [AWS Organizations User Guide](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_integrate_services.html). | |||
| * `enabled_policy_types` - (Optional) List of Organizations policy types to enable in the Organization Root. Organization must have `feature_set` set to `ALL`. For additional information about valid policy types (e.g. `SERVICE_CONTROL_POLICY`), see the [AWS Organizations API Reference](https://docs.aws.amazon.com/organizations/latest/APIReference/API_EnablePolicyType.html). | |||
| * `enabled_policy_types` - (Optional) List of Organizations policy types to enable in the Organization Root. Organization must have `feature_set` set to `ALL`. For additional information about valid policy types (e.g. `SERVICE_CONTROL_POLICY` and `SERVICE_CONTROL_POLICY`), see the [AWS Organizations API Reference](https://docs.aws.amazon.com/organizations/latest/APIReference/API_EnablePolicyType.html). | |||
There was a problem hiding this comment.
Should be TAG_POLICY -- will fix on merge.
There was a problem hiding this comment.
@bflad Thank you 😆
|
This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
This will allow support of tag policies (https://aws.amazon.com/about-aws/whats-new/2019/11/aws-launches-tag-policies/) to be enabled.
The change allows the keyword "TAG_POLICY" to be used in enabled_policy_types list for the aws_organizations_organization resource. Tests for policy types are slightly changed to allow for more flexible use and tests for the new value is added.
Related feature requests #11202 and #11032
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: