r/cloudhsmv2_cluster - support tag on create

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_cloudhsmv2_cluster: support tag on create

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudHsm2Cluster_'
--- PASS: TestAccAWSCloudHsm2Cluster_basic (345.82s)
--- PASS: TestAccAWSCloudHsm2Cluster_Tags (441.26s)

[ewbankkit]

I think you'll also have to update the Resource Tagging Code Implementation section of CONTRIBUTING.md as aws_cloudhsm_v2_hsm is the example used for resources that don't support tag-on-create.

[DrFaust92]

Thanks for noticing! Will do.

…

On Tue, Jan 21, 2020, 00:59 Kit Ewbank ***@***.***> wrote: I think you'll also have to update the *Resource Tagging Code Implementation* section of CONTRIBUTING.md <https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#resource-tagging-code-implementation> as aws_cloudhsm_v2_hsm is the example used for resources that don't support tag-on-create. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11683>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7VHT4PRWBQPX2L7ET3Q6YUDPANCNFSM4KJKXT2A> .

[bflad]

Looks great, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudHsmV2Cluster_basic (262.39s)
--- PASS: TestAccAWSCloudHsmV2Cluster_Tags (286.07s)

[ghost]

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!