Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: github.com/aws/aws-sdk-go@6ca8a5496cb4 #11727

Merged
merged 1 commit into from
Jan 23, 2020
Merged

deps: github.com/aws/aws-sdk-go@6ca8a5496cb4 #11727

merged 1 commit into from
Jan 23, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11682
Reference: aws/aws-sdk-go#3089

Release note for CHANGELOG:

* provider: Upgrade AWS Go SDK dependency to fix missing/incorrect API error messages and missing retries regression introduced in Terraform AWS Provider version 2.45.0

The fix for widespread error handling regression was merged upstream into the AWS Go SDK, however there was not a release today on the normal daily release cadence. This pulls in the commit after AWS Go SDK v1.28.7 containing the fix for the missing error messages that was merged yesterday so we can allow the full acceptance test suite to run overnight.

Updated via:

go get github.com/aws/aws-sdk-go@6ca8a5496cb4723ad4ef1e6709ed593ea81ce000
go mod tidy
go mod vendor

Output from acceptance testing (as a smoke test of the fixed behavior):

--- PASS: TestAccAWSCodeBuildProject_basic (37.35s)

@bflad
deps: github.com/aws/aws-sdk-go@6ca8a5496cb4
f8c65f5 
Reference: #11682
Reference: aws/aws-sdk-go#3089

The fix for widespread error handling regression was merged upstream into the AWS Go SDK, however there was not a release today on the normal daily release cadence. This pulls in the commit after AWS Go SDK v1.28.7 containing the fix for the missing error messages that was merged yesterday so we can allow the full acceptance test suite to run overnight.

Updated via:

```
go get github.com/aws/aws-sdk-go@6ca8a5496cb4723ad4ef1e6709ed593ea81ce000
go mod tidy
go mod vendor
```

Output from acceptance testing (as a smoke test of the fixed behavior):

```
--- PASS: TestAccAWSCodeBuildProject_basic (37.35s)
```
@bflad bflad added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label Jan 23, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 23, 2020
@bflad bflad requested a review from a team January 23, 2020 02:50
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. dependencies Used to indicate dependency changes. labels Jan 23, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2020
@bflad
Copy link
Contributor Author

bflad commented Jan 23, 2020

Apologies for the unusual self-merge -- trying to verify this potential regression fix overnight across the whole test suite so we can release on schedule tomorrow. We can revert if it causes unexpected issues.

@bflad bflad merged commit 1860e72 into master Jan 23, 2020
@bflad bflad deleted the v-aws-sdk-go-11682 branch January 23, 2020 03:08
bflad added a commit that referenced this pull request Jan 23, 2020
@bflad
Update CHANGELOG for #11727
b9b9d85
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.46.0
Development

Successfully merging this pull request may close these issues.

Terraform AWS Provider Version 2.45.0: Missing Error Messages and Not Retrying
1 participant
@bflad