Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/vpc: Ignore ClassicLink DNS support in unsupported regions #1176

Merged
merged 2 commits into from
Jul 18, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 18, 2017

This is to address the following tests

=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- FAIL: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (8.61s)
    testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_vpc.tftestvpc: 1 error(s) occurred:
        
        * aws_vpc.tftestvpc: AuthFailure: This request has been administratively disabled.
            status code: 403, request id: 34e0bacc-181c-4cb9-8b3f-bf43b7871e1d
    testing.go:492: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
--- FAIL: TestAccAWSNetworkAcl_ipv6VpcRules (8.84s)
    testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_vpc.foo: 1 error(s) occurred:
        
        * aws_vpc.foo: AuthFailure: This request has been administratively disabled.
            status code: 403, request id: aec9548e-ce1b-49c9-a5d5-1354230c73e1
    testing.go:492: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
=== RUN   TestAccDataSourceAwsRouteTable_main
--- FAIL: TestAccDataSourceAwsRouteTable_main (9.49s)
    testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_vpc.test: 1 error(s) occurred:
        
        * aws_vpc.test: AuthFailure: This request has been administratively disabled.
            status code: 403, request id: 18a7bb2c-581a-4867-9373-dd397310e93e
    testing.go:492: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

which started to fail after merging #1079

I did verify that this error only appears in unsupported region (us-east-2 in our case) and disappears in supported region (us-west-2).

Verified

This commit was signed with the committer’s verified signature.
radeksimko Radek Simko

Verified

This commit was signed with the committer’s verified signature.
radeksimko Radek Simko
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jul 18, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDefaultNetworkAcl_basicIpv6Vpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDefaultNetworkAcl_basicIpv6Vpc -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (68.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.219s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkAcl_ipv6VpcRules'       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNetworkAcl_ipv6VpcRules -timeout 120m
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (61.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.541s

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsRouteTable_main'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsRouteTable_main -timeout 120m
=== RUN   TestAccDataSourceAwsRouteTable_main
--- PASS: TestAccDataSourceAwsRouteTable_main (60.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.531s

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants