Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_vault: remove from state if manually deleted #11845

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11840

Release note for CHANGELOG:

resource_aws_backup_vault: remove from state if deleted

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAwsBackupVault_disappears (58.47s)

@DrFaust92 DrFaust92 requested a review from a team January 31, 2020 21:34
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 31, 2020
Copy link
Contributor

@slapula slapula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I accounted for that. Thanks for picking this up. Looks good!

@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 16, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 16, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest fan of doing this with AccessDeniedException since it potentially can hide an actual permissions issue, but since the API doesn't use ResourceNotFoundException, LGTM. Thanks, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAwsBackupVault_disappears (6.62s)
--- PASS: TestAccAwsBackupVault_basic (8.48s)
--- PASS: TestAccAwsBackupVault_withTags (18.50s)
--- PASS: TestAccAwsBackupVault_withKmsKey (27.09s)

@bflad bflad merged commit 65f7ee2 into hashicorp:master Mar 16, 2020
bflad added a commit that referenced this pull request Mar 16, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/backup-fix branch March 22, 2020 21:38
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/backup Issues and PRs that pertain to the backup service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_backup_vault does not reapply resource if manually removed account
3 participants