Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_msk_cluster: support Logging Info #12215

Merged
merged 1 commit into from
Mar 27, 2020
Merged

aws_msk_cluster: support Logging Info #12215

merged 1 commit into from
Mar 27, 2020

Conversation

arafsheikh
Copy link
Contributor

@arafsheikh arafsheikh commented Feb 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12186

Release note for CHANGELOG:

resource/aws_msk_cluster: support `logging_info` configuration [GH-12186]

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskCluster_LoggingInfo'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskCluster_LoggingInfo -timeout 120m
=== RUN   TestAccAWSMskCluster_LoggingInfo
=== PAUSE TestAccAWSMskCluster_LoggingInfo
=== CONT  TestAccAWSMskCluster_LoggingInfo
--- PASS: TestAccAWSMskCluster_LoggingInfo (1486.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1487.802s

@arafsheikh arafsheikh requested a review from a team February 28, 2020 23:01
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 28, 2020
@arafsheikh arafsheikh changed the title [WIP] aws_msk_cluster: support Logging Info aws_msk_cluster: support Logging Info Feb 28, 2020
@arafsheikh arafsheikh mentioned this pull request Feb 29, 2020
Closed
kamil-rogon-dragon
kamil-rogon-dragon suggested changes Mar 19, 2020
View reviewed changes
aws/resource_aws_msk_cluster.go Outdated Show resolved Hide resolved
aws/resource_aws_msk_cluster.go Outdated Show resolved Hide resolved
aws/resource_aws_msk_cluster.go Outdated Show resolved Hide resolved
aws/resource_aws_msk_cluster.go Outdated Show resolved Hide resolved
@arafsheikh arafsheikh force-pushed the master branch 2 times, most recently from 1722774 to 6635bab Compare March 19, 2020 17:21
@DrFaust92 DrFaust92 mentioned this pull request Mar 27, 2020
Closed
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 27, 2020
@bflad bflad linked an issue Mar 27, 2020 that may be closed by this pull request
Released Feb 26, 2020: Amazon MSK can now stream broker logs to CloudWatch Logs, Amazon S3, or Amazon Elasticsearch Service #12550
Closed
@bflad bflad self-assigned this Mar 27, 2020
@bflad bflad added this to the v2.55.0 milestone Mar 27, 2020
bflad
bflad approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @arafsheikh 🚀

Output from acceptance testing:

--- PASS: TestAccAWSMskCluster_basic (818.33s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (910.16s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (921.25s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (933.26s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (986.14s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (998.17s)
--- PASS: TestAccAWSMskCluster_Tags (1021.85s)
--- PASS: TestAccAWSMskCluster_OpenMonitoring (1118.75s)
--- PASS: TestAccAWSMskCluster_LoggingInfo (1217.09s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (1472.97s)

@bflad bflad merged commit 20c85c1 into hashicorp:master Mar 27, 2020
bflad added a commit that referenced this pull request Mar 27, 2020
@bflad
Update CHANGELOG for #12215
e44d82a
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.55.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kamil-rogon-dragon kamil-rogon-dragon kamil-rogon-dragon requested changes

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.55.0
3 participants
@arafsheikh @bflad @kamil-rogon-dragon