Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Remove assumeRoleHash #1227

Merged
merged 2 commits into from
Jul 25, 2017
Merged

provider: Remove assumeRoleHash #1227

merged 2 commits into from
Jul 25, 2017

Conversation

grubernaut
Copy link
Contributor

The default hash function is good enough to use for the assume_role schema,
previously the custom hash function was causing a panic in the provider if the
assume_role configuration block was present but empty.

Fixes: #1213

@grubernaut
provider: Remove assumeRoleHash
5f8f380 
The default hash function is good enough to use for the `assume_role` schema,
previously the custom hash function was causing a panic in the provider if the
`assume_role` configuration block was present but empty.
@grubernaut grubernaut added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jul 24, 2017
@grubernaut grubernaut requested a review from catsby July 24, 2017 20:26
catsby
catsby approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we use the example block from #1213 as a regression test?

catsby
catsby approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grubernaut grubernaut merged commit 4b29cb7 into master Jul 25, 2017
@grubernaut grubernaut deleted the f-empty-assume-role branch July 25, 2017 19:43
@charles-at-geospock
Copy link
Contributor

Awesome; thanks guys :)

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty assume_role causes a crash
3 participants
@grubernaut @charles-at-geospock @catsby