r/aws_api_gateway_rest_api - fix vpc endpoint updates #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
needs-triage
|
Verified acceptance test: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint -timeout 120m
=== RUN TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== CONT TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (368.50s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 368.541s |
bflad
added
bug
bflad
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Looks good, thanks for this fix, @DrFaust92 🚀 For the CHANGELOG entry we'll put something along the lines of:
* resource/aws_api_gateway_rest_api: Ignore ordering differences for `endpoint_configuration` configuration block `vpc_endpoint_ids` argument
Output from acceptance testing:
--- PASS: TestAccAWSAPIGatewayRestApi_policy (63.79s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (107.95s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (136.84s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (198.10s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (253.35s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (370.96s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (379.97s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (387.07s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (508.50s)
bflad
added a commit
that referenced
this pull request
Mar 17, 2020
|
This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
bflad
added a commit
that referenced
this pull request
Apr 15, 2020
… configured APIs Reference: #12350 Reference: #8223 Previously: ``` TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds: testing.go:669: Step 0 error: errors during apply: Error: error setting endpoint_configuration: endpoint_configuration.0.vpc_endpoint_ids: '': source data must be an array or slice, got struct on /var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/tf-test660234204/main.tf line 62: (source code not available) ``` Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (18.71s) --- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (151.75s) --- PASS: TestAccAWSAPIGatewayRestApi_tags (66.14s) --- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (89.86s) --- PASS: TestAccAWSAPIGatewayRestApi_disappears (118.54s) --- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (187.17s) --- PASS: TestAccAWSAPIGatewayRestApi_openapi (239.32s) --- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (370.75s) --- PASS: TestAccAWSAPIGatewayRestApi_policy (459.60s) --- PASS: TestAccAWSAPIGatewayRestApi_basic (505.99s) --- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (690.91s) ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #12210
Release note for CHANGELOG:
Output from acceptance testing: