Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_plan - add import support #12381

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12380

Release note for CHANGELOG:

resource_aws_backup_plan - add import support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupPlan_'
--- PASS: TestAccAwsBackupPlan_basic (49.44s)
--- PASS: TestAccAwsBackupPlan_withTags (131.62s)
--- PASS: TestAccAwsBackupPlan_withRules (109.21s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (138.57s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (109.30s)
--- PASS: TestAccAwsBackupPlan_disappears (40.02s).

@DrFaust92 DrFaust92 requested a review from a team March 13, 2020 10:59
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2020
@ghost ghost added service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 13, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 120m
=== RUN   TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN   TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN   TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN   TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_basic
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT  TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_withRules
=== CONT  TestAccAwsBackupPlan_withLifecycle
=== CONT  TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (25.35s)
--- PASS: TestAccAwsBackupPlan_basic (29.28s)
--- PASS: TestAccAwsBackupPlan_withTags (65.61s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (65.62s)
--- PASS: TestAccAwsBackupPlan_withRules (65.79s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (83.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	83.324s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 16, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 16, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAwsBackupPlan_disappears (8.57s)
--- PASS: TestAccAwsBackupPlan_basic (9.42s)
--- PASS: TestAccAwsBackupPlan_withTags (19.27s)
--- PASS: TestAccAwsBackupPlan_withRules (19.68s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (19.80s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (24.37s)

@bflad bflad merged commit 7222645 into hashicorp:master Mar 16, 2020
bflad added a commit that referenced this pull request Mar 16, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ricardclau
Copy link

Hi! Just wanted to share I managed to import an existing backup plan flawlessly. Thank you so much for implementing this!

@DrFaust92 DrFaust92 deleted the backup-plan-import branch March 22, 2020 21:40
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform import for aws_backup_plan?
4 participants