-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_backup_plan - add import support #12381
Conversation
Verified acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 120m
=== RUN TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT TestAccAwsBackupPlan_basic
=== CONT TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT TestAccAwsBackupPlan_disappears
=== CONT TestAccAwsBackupPlan_withRules
=== CONT TestAccAwsBackupPlan_withLifecycle
=== CONT TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (25.35s)
--- PASS: TestAccAwsBackupPlan_basic (29.28s)
--- PASS: TestAccAwsBackupPlan_withTags (65.61s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (65.62s)
--- PASS: TestAccAwsBackupPlan_withRules (65.79s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (83.26s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 83.324s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccAwsBackupPlan_disappears (8.57s)
--- PASS: TestAccAwsBackupPlan_basic (9.42s)
--- PASS: TestAccAwsBackupPlan_withTags (19.27s)
--- PASS: TestAccAwsBackupPlan_withRules (19.68s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (19.80s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (24.37s)
This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
Hi! Just wanted to share I managed to import an existing backup plan flawlessly. Thank you so much for implementing this! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #12380
Release note for CHANGELOG:
Output from acceptance testing: