Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_global_cluster: Add aurora-postgresql to engine argument plan-time validation #12401

Merged
merged 1 commit into from
Apr 9, 2020
Merged

resource/aws_rds_global_cluster: Add aurora-postgresql to engine argument plan-time validation #12401

merged 1 commit into from
Apr 9, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 16, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12382

Release note for CHANGELOG:

* resource/aws_rds_global_cluster: Add `aurora-postgresql` to `engine` argument plan-time validation

Output from acceptance testing:

--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (16.51s)

@bflad
resource/aws_rds_global_cluster: Add aurora-postgresql to engine argu…
68951a1 
…ment plan-time validation

Reference: #12382

Output from acceptance testing:

```
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (16.51s)
```
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 16, 2020
@bflad bflad requested a review from a team March 16, 2020 02:01
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 16, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2020
@bflad bflad mentioned this pull request Mar 16, 2020
Closed
@achanda
Copy link

achanda commented Mar 17, 2020

Hi @bflad is there anything else required before this can be merged? Happy to help if I can expedite this.

@rajholla
Copy link
Contributor

rajholla commented Apr 1, 2020

Is there anything pending before we merge this?

@fphilippon
Copy link

How can we help to have this merged?

gdavison
gdavison approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSRdsGlobalCluster_disappears (10.36s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (10.78s)
--- PASS: TestAccAWSRdsGlobalCluster_basic (10.93s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (11.01s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (11.36s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (11.78s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (18.02s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (18.16s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (18.34s)

@gdavison gdavison added this to the v2.57.0 milestone Apr 9, 2020
@bflad bflad merged commit 14e121b into master Apr 9, 2020
@bflad bflad deleted the f-aws_rds_global_cluster-postgres branch April 9, 2020 21:11
bflad added a commit that referenced this pull request Apr 9, 2020
@bflad
Update CHANGELOG for #12401
ff6b307
@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.57.0
Development

Successfully merging this pull request may close these issues.

aws_rds_global_cluster does not support aurora-postgresql
5 participants
@bflad @achanda @rajholla @fphilippon @gdavison