Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/launch_template - add hibernation options #12492

Merged
merged 5 commits into from
Mar 30, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 20, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6638

Release note for CHANGELOG:

resource_aws_launch_template - add `hibernation_options` block
data_source_aws_launch_template - add `hibernation_options` block

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_hibernation'
--- PASS: TestAccAWSLaunchTemplate_hibernation (476.57s)
$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_basic'
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (237.30s)

@DrFaust92 DrFaust92 requested a review from a team March 20, 2020 21:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 20, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (21.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.589s
 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_hibernation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_hibernation -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== CONT  TestAccAWSLaunchTemplate_hibernation
--- PASS: TestAccAWSLaunchTemplate_hibernation (57.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.632s

@bflad
Copy link
Contributor

bflad commented Mar 27, 2020

This currently has a merge conflict due to merging #12403 but I would hold off fixing that since #12491 will likely also cause issues.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 27, 2020
@bflad bflad self-assigned this Mar 27, 2020
@DrFaust92
Copy link
Collaborator Author

Thanks for the heads up, I'll rebase this after #12491 is merged.

@bflad
Copy link
Contributor

bflad commented Mar 27, 2020

Ready for rebase!

@DrFaust92 DrFaust92 force-pushed the rd/launch_template_hibernation branch from d2a0afb to 41869e8 Compare March 27, 2020 19:25
@DrFaust92 DrFaust92 force-pushed the rd/launch_template_hibernation branch from ab374aa to 80fd481 Compare March 27, 2020 19:47
@DrFaust92
Copy link
Collaborator Author

@bflad , done with rebase.
having an issue connection to my workplace VPN to run this so i may not be able test this at the moment.

@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented Mar 29, 2020

@bflad, done.

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_hibernation'
--- PASS: TestAccAWSLaunchTemplate_hibernation (98.74s)
$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_basic'
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (49.79s)

@bflad bflad added this to the v2.56.0 milestone Mar 30, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (36.84s)
--- PASS: TestAccAWSLaunchTemplate_basic (15.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (46.04s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (50.78s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (15.50s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (19.67s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (13.08s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (13.92s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (15.54s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (15.53s)
--- PASS: TestAccAWSLaunchTemplate_data (15.38s)
--- PASS: TestAccAWSLaunchTemplate_description (23.28s)
--- PASS: TestAccAWSLaunchTemplate_disappears (11.34s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (49.74s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (27.37s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (27.45s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (16.01s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (46.97s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (13.77s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (19.10s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (26.05s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (13.00s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (10.30s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (23.89s)
--- PASS: TestAccAWSLaunchTemplate_tags (28.56s)
--- PASS: TestAccAWSLaunchTemplate_update (43.83s)

--- PASS: TestAccAWSLaunchTemplateDataSource_basic (17.35s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (19.83s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (15.37s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (17.23s)

@bflad bflad merged commit 95f3e0b into hashicorp:master Mar 30, 2020
bflad added a commit that referenced this pull request Mar 30, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the rd/launch_template_hibernation branch April 7, 2020 14:56
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

1 similar comment
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EC2 Hibernate Options
3 participants