-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/launch_template - add hibernation options #12492
rd/launch_template - add hibernation options #12492
Conversation
Verified acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== CONT TestAccAWSLaunchTemplateDataSource_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (21.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 21.589s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_hibernation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_hibernation -timeout 120m
=== RUN TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== CONT TestAccAWSLaunchTemplate_hibernation
--- PASS: TestAccAWSLaunchTemplate_hibernation (57.59s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 57.632s |
Thanks for the heads up, I'll rebase this after #12491 is merged. |
Ready for rebase! |
d2a0afb
to
41869e8
Compare
ab374aa
to
80fd481
Compare
@bflad , done with rebase. |
@bflad, done.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (36.84s)
--- PASS: TestAccAWSLaunchTemplate_basic (15.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (46.04s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (50.78s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (15.50s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (19.67s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (13.08s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (13.92s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (15.54s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (15.53s)
--- PASS: TestAccAWSLaunchTemplate_data (15.38s)
--- PASS: TestAccAWSLaunchTemplate_description (23.28s)
--- PASS: TestAccAWSLaunchTemplate_disappears (11.34s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (49.74s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (27.37s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (27.45s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (16.01s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (46.97s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (13.77s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (19.10s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (26.05s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (13.00s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (10.30s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (23.89s)
--- PASS: TestAccAWSLaunchTemplate_tags (28.56s)
--- PASS: TestAccAWSLaunchTemplate_update (43.83s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (17.35s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (19.83s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (15.37s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (17.23s)
This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
1 similar comment
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #6638
Release note for CHANGELOG:
Output from acceptance testing: