New Data Source: aws_efs_mount_target #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: hashicorp#1207 ``` % make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEfsMountTarget' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsEfsMountTarget -timeout 120m === RUN TestAccDataSourceAwsEfsMountTargetByMountTargetId --- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (253.06s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 253.094s ```
Ninir
added
the
enhancement
grubernaut
suggested changes
Jul 28, 2017
| Provides an Elastic File System Mount Target (EFS) data source. | ||
| --- | ||
|
|
||
| # aws_efs_file_system |
There was a problem hiding this comment.
nit: use the \ escape prior to the skids here
|
I no longer believe that escaping these is necessary - I think it may have
been @sethvargo that told me that?
…On Fri, 28 Jul 2017 at 17:38, Jake Champlin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
LGTM, only one minor doc nit. Thanks!
------------------------------
In website/docs/d/efs_mount_target.html.markdown
<#1255 (comment)>
:
> @@ -0,0 +1,42 @@
+---
+layout: "aws"
+page_title: "AWS: efs_file_system"
+sidebar_current: "docs-aws-datasource-efs-file-system"
+description: |-
+ Provides an Elastic File System Mount Target (EFS) data source.
+---
+
+# aws_efs_file_system
nit: use the \ escape prior to the skids here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1255 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN57zvOuyXyi_0IXpqsfOgrqIYVNYjEks5sSfJzgaJpZM4OlLRy>
.
|
|
Correct |
grubernaut
approved these changes
Jul 28, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1207