Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional bandwidth options for Direct Connect #12559

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add additional bandwidth options for Direct Connect #12559

merged 1 commit into from
Mar 30, 2020

Conversation

eddieramirez
Copy link
Contributor

Signed-off-by: Eddie Ramirez eddieramirez@me.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12558

Release note for CHANGELOG:


* resource/aws_dx_connection: Support additional bandwidth speeds. [GH-12558]
* resource/aws_dx_lag: Support additional bandwidth speeds. [GH-12558]

Output from acceptance testing:

 $ make testacc TESTARGS='-run=TestValidateDxConnectionBandWidth'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestValidateDxConnectionBandWidth -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestValidateDxConnectionBandWidth
--- PASS: TestValidateDxConnectionBandWidth (0.00s)
PASS

...

@eddieramirez eddieramirez requested a review from a team March 27, 2020 20:33
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 27, 2020
@ewbankkit
Copy link
Contributor

LGTM.

bflad
bflad approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @eddieramirez 🚀

@bflad bflad added this to the v2.56.0 milestone Mar 30, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 30, 2020
@bflad bflad merged commit f157566 into hashicorp:master Mar 30, 2020
bflad added a commit that referenced this pull request Mar 30, 2020
@bflad
Update CHANGELOG for #12559
a448d0c
@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

1 similar comment
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.56.0
Development

Successfully merging this pull request may close these issues.

No Support for 2Gbps/5Gbps in Direct Connect Hosted Connections
3 participants
@eddieramirez @ewbankkit @bflad