Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_patch_baseline: Update support for Operating System #1260

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 27, 2017

Fixes: #1257

I am going to add operating_system and
approved_patches_compliance_level only in this PR - I believe that an
overhaul of SSM to remove ForceNew from all of SSM resources can be
added in a follow up PR if that suffices

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMPatchBaseline -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (43.22s)
=== RUN   TestAccAWSSSMPatchBaselineWithOperatingSystem
--- PASS: TestAccAWSSSMPatchBaselineWithOperatingSystem (23.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.691s

Fixes: hashicorp#1257

I am going to add `operating_system` and
`approved_patches_compliance_level` only in this PR - I believe that an
overhaul of SSM to remove ForceNew from all of SSM resources can be
added in a follow up PR if that suffices

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMPatchBaseline -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (43.22s)
=== RUN   TestAccAWSSSMPatchBaselineWithOperatingSystem
--- PASS: TestAccAWSSSMPatchBaselineWithOperatingSystem (23.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.691s
```
@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 28, 2017
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work here

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Multiple improvements to aws_ssm_patch_baseline
3 participants