Change EC2 Instance root volume size without re-creating #12620

gdavison · 2020-04-01T21:02:23Z

This PR picks up on the work done by @viscat in #1396 to allow changing EC2 instance root volume size without re-creating the instance.

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1396
Closes #768
Closes #8729
Closes #4219
Closes #4196
Closes #609
Closes #418
Closes #172
Closes #139
Closes #105

Release note for CHANGELOG:

resource/aws_instance: Allow changing root volume size without re-creating resource
resource/aws_instance: Exports `volume_name` for `root_block_device`
data-source/aws_instance: Returns `volume_name` for `root_block_device`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSInstance_'

--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (279.76s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (66.94s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (97.32s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (122.86s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (117.01s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (125.10s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (116.33s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (135.45s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (86.46s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (127.49s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (73.44s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (90.68s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (85.17s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (84.62s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (192.94s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (77.00s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (301.24s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (86.14s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (88.58s)
--- PASS: TestAccAWSInstance_addSecondaryInterface (129.52s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (124.41s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (75.43s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (105.55s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (69.46s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (86.34s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (71.78s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (89.85s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (92.80s)
--- PASS: TestAccAWSInstance_basic (130.01s)
--- PASS: TestAccAWSInstance_blockDevices (80.54s)
--- PASS: TestAccAWSInstance_changeInstanceType (241.52s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (110.11s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (116.89s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (323.91s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (133.02s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (117.66s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (93.15s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (413.14s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (73.28s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (314.39s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (97.38s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (392.44s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (76.55s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (113.49s)
--- PASS: TestAccAWSInstance_disableApiTermination (116.04s)
--- PASS: TestAccAWSInstance_disappears (224.59s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (243.26s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (148.03s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (170.56s)
--- PASS: TestAccAWSInstance_hibernation (365.55s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (83.62s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (64.52s)
--- PASS: TestAccAWSInstance_instanceProfileChange (195.15s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.90s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (85.75s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (75.29s)
--- PASS: TestAccAWSInstance_keyPairCheck (63.96s)
--- PASS: TestAccAWSInstance_metadataOptions (117.30s)
--- PASS: TestAccAWSInstance_multipleRegions (251.16s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (176.35s)
--- PASS: TestAccAWSInstance_placementGroup (58.66s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (200.28s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (80.50s)
--- PASS: TestAccAWSInstance_privateIP (105.85s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (65.40s)
--- PASS: TestAccAWSInstance_rootInstanceStore (80.19s)
--- PASS: TestAccAWSInstance_sourceDestCheck (135.51s)
--- PASS: TestAccAWSInstance_tags (117.10s)
--- PASS: TestAccAWSInstance_userDataBase64 (131.52s)
--- PASS: TestAccAWSInstance_volumeTags (103.12s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (104.15s)
--- PASS: TestAccAWSInstance_vpc (105.62s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (116.03s)

$ make testacc TESTARGS='-run=TestAccAWSInstanceDataSource_'

--- PASS: TestAccAWSInstanceDataSource_AzUserData (127.32s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (120.33s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (281.72s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (121.36s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (91.08s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (129.05s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (252.55s)
--- PASS: TestAccAWSInstanceDataSource_VPC (99.88s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (82.35s)
--- PASS: TestAccAWSInstanceDataSource_basic (239.47s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (88.09s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (94.08s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (145.38s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (158.64s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (185.66s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (68.87s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (164.02s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (71.22s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (113.55s)
--- PASS: TestAccAWSInstanceDataSource_tags (238.13s)

$ make testacc TESTARGS='-run=TestAccAWSSSMAssociation_'

--- PASS: TestAccAWSSSMAssociation_basic (75.04s)
--- PASS: TestAccAWSSSMAssociation_rateControl (19.04s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (14.00s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (14.62s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (34.09s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (18.50s)
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (8.35s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (30.30s)
--- PASS: TestAccAWSSSMAssociation_withParameters (13.85s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (15.64s)
--- PASS: TestAccAWSSSMAssociation_withTargets (19.89s)

$ make testacc TESTARGS='-run=TestAccAWSSpotInstanceRequest'

--- PASS: TestAccAWSSpotInstanceRequestInterruptHibernate (300.50s)
--- PASS: TestAccAWSSpotInstanceRequestInterruptStop (280.14s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (104.42s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (104.18s)
--- PASS: TestAccAWSSpotInstanceRequest_basic (117.23s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (240.54s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (99.43s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (104.18s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (109.66s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (59.89s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (78.79s)

…ation Fixes: #768 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_changeRootBlockDeviceVolumeSize' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSInstance_changeRootBlockDeviceVolumeSize -timeout 120m === RUN TestAccAWSInstance_changeRootBlockDeviceVolumeSize --- PASS: TestAccAWSInstance_changeRootBlockDeviceVolumeSize (514.63s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 514.642s

…ched

… volume is useable in that state

bflad

A few minor items, otherwise should be good. Optimistically approving if testing passes after adjustments.

--- PASS: TestAccAWSInstance_addSecondaryInterface (122.31s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (122.67s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (64.73s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (75.18s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (68.66s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (66.56s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.00s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (75.07s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (74.73s)
--- PASS: TestAccAWSInstance_basic (159.50s)
--- PASS: TestAccAWSInstance_blockDevices (80.22s)
--- PASS: TestAccAWSInstance_changeInstanceType (334.90s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (312.25s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (102.67s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (86.54s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (419.52s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (75.88s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (311.93s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (91.99s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (423.78s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (101.01s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (98.01s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (132.57s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (76.27s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (103.46s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (61.87s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (118.21s)
--- PASS: TestAccAWSInstance_disableApiTermination (107.31s)
--- PASS: TestAccAWSInstance_disappears (226.03s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (97.63s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (63.62s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (152.77s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (121.64s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (132.01s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (122.18s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (122.59s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (96.93s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (125.78s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (255.68s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (134.80s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (160.99s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (182.43s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (94.65s)
--- PASS: TestAccAWSInstance_hibernation (206.34s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (83.33s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (73.75s)
--- PASS: TestAccAWSInstance_instanceProfileChange (164.48s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (84.50s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (99.10s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (15.72s)
--- PASS: TestAccAWSInstance_keyPairCheck (174.73s)
--- PASS: TestAccAWSInstance_metadataOptions (113.03s)
--- PASS: TestAccAWSInstance_multipleRegions (164.47s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (82.26s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (76.31s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (77.33s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (175.46s)
--- PASS: TestAccAWSInstance_placementGroup (66.09s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (86.38s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (76.65s)
--- PASS: TestAccAWSInstance_privateIP (74.48s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (313.08s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (64.24s)
--- PASS: TestAccAWSInstance_rootInstanceStore (79.33s)
--- PASS: TestAccAWSInstance_sourceDestCheck (136.65s)
--- PASS: TestAccAWSInstance_tags (207.62s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (86.80s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (81.27s)
--- PASS: TestAccAWSInstance_userDataBase64 (221.77s)
--- PASS: TestAccAWSInstance_volumeTags (113.18s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (103.94s)
--- PASS: TestAccAWSInstance_vpc (85.97s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (219.37s)

--- PASS: TestAccAWSInstanceDataSource_AzUserData (273.70s)
--- PASS: TestAccAWSInstanceDataSource_basic (268.08s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (106.01s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (88.93s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (126.69s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (138.18s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (155.75s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (119.26s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (125.23s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (97.60s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (80.24s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (117.67s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (65.98s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (89.75s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (112.14s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (106.41s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (241.64s)
--- PASS: TestAccAWSInstanceDataSource_tags (117.86s)
--- PASS: TestAccAWSInstanceDataSource_VPC (200.57s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (88.62s)

--- PASS: TestAccAWSInstancesDataSource_basic (195.26s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (171.88s)
--- PASS: TestAccAWSInstancesDataSource_tags (202.67s)

--- PASS: TestAccAWSSpotInstanceRequest_basic (109.96s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (260.07s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (74.52s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (93.08s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (91.97s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (116.23s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (78.95s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (113.04s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (58.49s)
--- PASS: TestAccAWSSpotInstanceRequestInterruptHibernate (289.76s)
--- PASS: TestAccAWSSpotInstanceRequestInterruptStop (290.03s)

--- PASS: TestAccAWSSSMAssociation_basic (75.83s)
--- PASS: TestAccAWSSSMAssociation_rateControl (15.49s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (17.23s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (15.64s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (24.75s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (21.99s)
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (10.79s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (33.64s)
--- PASS: TestAccAWSSSMAssociation_withParameters (13.89s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (39.35s)
--- PASS: TestAccAWSSSMAssociation_withTargets (19.13s)

aws/resource_aws_instance.go

ghost · 2020-04-17T00:43:18Z

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-17T17:10:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

viscat and others added 3 commits April 1, 2020 12:52

Improve code quality and fix tests as requested

ce7c8c0

Updates to current framework

a06f077

gdavison changed the title ~~Resource aws instance/root volume size update~~ Change EC2 Instance root volume size without re-creating Apr 1, 2020

gdavison mentioned this pull request Apr 1, 2020

Modify root volume size without instance recreation #1396

Closed

gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Apr 1, 2020

Consolidates EC2 instance retrieval

9b9fbf0

ghost added service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 2, 2020

gdavison added 2 commits April 2, 2020 15:01

Uses AWS SDK provided functions for value dereference

a9ff570

Updates root volume resize to work when multiple EBS volumes are atta…

739e70d

…ched

ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 2, 2020

Stops waiting for volume update when state is optimizing, since the…

9dbb61e

… volume is useable in that state

gdavison marked this pull request as ready for review April 3, 2020 00:18

gdavison requested a review from a team April 3, 2020 00:18

gdavison added 2 commits April 2, 2020 17:20

Updates documentation

46d5fe0

Adds test for retrieving computed root EBS device values

8f146ff

gdavison force-pushed the resource_aws_instance/root_volume_size_update branch from abe01fa to 8f146ff Compare April 4, 2020 00:18

Adds EBS root volume type and IOPS modification

229333c

gdavison force-pushed the resource_aws_instance/root_volume_size_update branch from a46b4eb to 229333c Compare April 6, 2020 23:09

Adds EBS root volume delete-on-termination modification

7674d3a

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 7, 2020

Adds device_name to data-source/aws_instance

0ceb4ae

bflad approved these changes Apr 14, 2020

View reviewed changes

Removes extraneous API call when updating root EBS volume

580b877

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 16, 2020

Adds checks for nil results to prevent panics

881f725

gdavison added this to the v2.58.0 milestone Apr 16, 2020

gdavison merged commit 2a1f934 into master Apr 16, 2020

gdavison added a commit that referenced this pull request Apr 16, 2020

Update CHANGELOG for #12620

5803dc7

gdavison deleted the resource_aws_instance/root_volume_size_update branch April 18, 2020 00:17

ghost locked and limited conversation to collaborators May 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change EC2 Instance root volume size without re-creating #12620

Change EC2 Instance root volume size without re-creating #12620

gdavison commented Apr 1, 2020 •

edited

Loading

bflad left a comment

ghost commented Apr 17, 2020

ghost commented May 17, 2020

Change EC2 Instance root volume size without re-creating #12620

Change EC2 Instance root volume size without re-creating #12620

Conversation

gdavison commented Apr 1, 2020 • edited Loading

Community Note

bflad left a comment

Choose a reason for hiding this comment

ghost commented Apr 17, 2020

ghost commented May 17, 2020

gdavison commented Apr 1, 2020 •

edited

Loading