Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/directory_service_service_directory - fix import + add attributes #12654

Merged
merged 17 commits into from
Jun 1, 2020
Merged

r/directory_service_service_directory - fix import + add attributes #12654

merged 17 commits into from
Jun 1, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 3, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10716

Release note for CHANGELOG:

resource_aws_directory_service_service_directory: add `availability_zones` attribute to `vpc_settings` block.
resource_aws_directory_service_service_directory: add `availability_zones` attribute to `connect_settings` block.
resource_aws_directory_service_service_directory: add plan time validation to `customer_dns_ips` in `connect_settings` block.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDirectoryServiceDirectory_'
--- PASS: TestAccAWSDirectoryServiceDirectory_disappears (814.29s)
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (596.66s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1876.52s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1694.06s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1092.28s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (837.93s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (803.25s)

@DrFaust92 DrFaust92 requested a review from a team April 3, 2020 14:55
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/directoryservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 3, 2020
@DrFaust92 DrFaust92 changed the title r/directory_service_service_directory - fix import + add attributes [WIP]r/directory_service_service_directory - fix import + add attributes Apr 3, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/directory_service_service_directory - fix import + add attributes r/directory_service_service_directory - fix import + add attributes Apr 3, 2020
@DrFaust92 DrFaust92 mentioned this pull request May 19, 2020
Merged
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label May 19, 2020
@gdavison gdavison self-assigned this May 19, 2020
gdavison
gdavison requested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing so much cleanup!

I'd like to leave the connect_ips, since #13395 adds the proper attributes. Otherwise, LGTM 🚀

--- PASS: TestAccAWSDirectoryServiceDirectory_disappears (576.76s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (608.26s)
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (626.64s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (652.30s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (680.59s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1091.45s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1668.22s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1679.64s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1798.28s)

@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label May 28, 2020
DrFaust92 and others added 13 commits May 28, 2020 22:33
@DrFaust92 DrFaust92 force-pushed the r/directory_service_service_directory_import branch from c153d93 to fb2f556 Compare May 28, 2020 19:35
@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented May 28, 2020 •
edited
Loading 

--- PASS: TestAccAWSDirectoryServiceDirectory_basic (613.38s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (745.58s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1813.82s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1784.81s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (788.02s)
--- PASS: TestAccAWSDirectoryServiceDirectory_disappears (611.80s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1064.39s)

@gdavison, ready for review

@DrFaust92 DrFaust92 requested a review from gdavison May 28, 2020 22:16
@gdavison gdavison removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 1, 2020
gdavison
gdavison approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSDirectoryServiceDirectory_disappears (557.22s)
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (591.65s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (620.39s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (663.82s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (672.74s)
--- PASS: TestAccDataSourceAWSDirectoryServiceDirectory_connector (1122.09s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1161.60s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1664.87s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1717.51s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1747.39s)

@gdavison gdavison merged commit f5a8c9f into hashicorp:master Jun 1, 2020
@gdavison gdavison added this to the v2.65.0 milestone Jun 1, 2020
gdavison added a commit that referenced this pull request Jun 1, 2020
@gdavison
Update CHANGELOG for #12654
86f59a5
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/directory_service_service_directory_import branch June 23, 2020 11:27
@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.65.0
Development

Successfully merging this pull request may close these issues.

import aws_directory_service_directory doesn't import connect_settings
2 participants
@DrFaust92 @gdavison