New resource aws_db_proxy_default_target_group

[gazoakley]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12690

Release note for CHANGELOG:

**New Resource:** `aws_db_proxy_default_target_group` (#12743)

Output from acceptance testing:

$testacc TESTARGS='-run=TestAccAWSDBProxyDefaultTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBProxyDefaultTargetGroup_ -timeout 120m
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_Basic
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_Basic
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_InitQuery
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_InitQuery
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters
=== RUN   TestAccAWSDBProxyDefaultTargetGroup_disappears
=== PAUSE TestAccAWSDBProxyDefaultTargetGroup_disappears
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_Basic
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_disappears
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_InitQuery
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent
=== CONT  TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_InitQuery (628.75s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters (692.52s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_Basic (722.49s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout (756.94s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent (778.10s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent (788.87s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (848.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	851.610s

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[bflad]

@gazoakley just merged in aws_db_proxy if you would like to rebase this pull request 🎉 then I can go through this. I think I'm agreeing with this initial implementation of a separate "default" target group resource since its semantics will be different than ones that can potentially be fully managed in the future. 👍

[gazoakley]

@bflad Rebased 👍 . I think I remember seeing in the documentation references to associate target groups with proxies, but there's no actual API operation to do so. I guess AWS intended to provide that function but removed it late on/didn't complete it as the only actual way to create a target group is to create a proxy (which in turn creates the default). Given there are API calls to DescribeDBProxyTargetGroups/ModifyDBProxyTargetGroup having a separate resource seems like the "Terraform way" of doing things hence why I've gone this route.

[bflad]

Hi again @gazoakley 👋 Here's the initial round of feedback. Thank you for splitting up the acceptance testing early! Please reach out if you have any questions or do not have time to implement the items. 👍

[bflad]

Looks good, thank you @gazoakley 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDBProxyDefaultTargetGroup_Basic (737.81s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent (740.15s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent (748.09s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters (756.04s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_InitQuery (765.73s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout (780.68s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (786.01s)

[ghost]

This has been released in version 3.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!