-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: aws_wafv2_rule_group #12790
New data source: aws_wafv2_rule_group #12790
Conversation
19f9131
to
c263d23
Compare
hi @pvanbuijtene 👋 -- dropping a note here to rebase and isolate the data_source changes when you get a chance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvanbuijtene implementation is off to great start! just some initial comments here in addition to the rebase comment above
c263d23
to
1c3c4b1
Compare
hi @pvanbuijtene, dropping a note here to please rebase :) |
68ff843
to
ae6effe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Holding off acceptance test validation until the resource is merged #12677
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one documentation note, otherwise LGTM 👍
Output of acceptance test:
--- PASS: TestAccDataSourceAwsWafv2RuleGroup_Basic (29.27s)
ae6effe
to
7ccc9a4
Compare
@anGie44 the documentation is updated. |
This has been released in version 2.66.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #11180
Relates #11046
Depends on #12677 because of duplicated code for tests.
Release note for CHANGELOG:
Output from acceptance testing: