Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: aws_wafv2_rule_group #12790

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

pvanbuijtene
Copy link
Contributor

@pvanbuijtene pvanbuijtene commented Apr 12, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11180
Relates #11046
Depends on #12677 because of duplicated code for tests.

Release note for CHANGELOG:

**New Data Source:** `aws_wafv2_rule_group` (#12790)

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWafv2RuleGroup'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2RuleGroup -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2RuleGroup_Basic
=== PAUSE TestAccDataSourceAwsWafv2RuleGroup_Basic
=== CONT  TestAccDataSourceAwsWafv2RuleGroup_Basic
--- PASS: TestAccDataSourceAwsWafv2RuleGroup_Basic (45.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       45.694s

@pvanbuijtene pvanbuijtene requested a review from a team April 12, 2020 17:00
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/wafv2 Issues and PRs that pertain to the wafv2 service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 12, 2020
@bflad bflad added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-rule-group-data-source branch from 19f9131 to c263d23 Compare May 7, 2020 20:31
@anGie44
Copy link
Contributor

anGie44 commented May 12, 2020

hi @pvanbuijtene 👋 -- dropping a note here to rebase and isolate the data_source changes when you get a chance :)

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvanbuijtene implementation is off to great start! just some initial comments here in addition to the rebase comment above

@pvanbuijtene pvanbuijtene force-pushed the wafv2-rule-group-data-source branch from c263d23 to 1c3c4b1 Compare May 16, 2020 07:14
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels May 16, 2020
@anGie44
Copy link
Contributor

anGie44 commented May 19, 2020

hi @pvanbuijtene, dropping a note here to please rebase :)

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label May 19, 2020
@maryelizbeth maryelizbeth added this to the Roadmap milestone May 19, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-rule-group-data-source branch from 68ff843 to ae6effe Compare May 22, 2020 18:02
@pvanbuijtene pvanbuijtene requested a review from anGie44 May 22, 2020 18:13
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Holding off acceptance test validation until the resource is merged #12677

@anGie44 anGie44 removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 8, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one documentation note, otherwise LGTM 👍

Output of acceptance test:

--- PASS: TestAccDataSourceAwsWafv2RuleGroup_Basic (29.27s)

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 8, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-rule-group-data-source branch from ae6effe to 7ccc9a4 Compare June 9, 2020 19:37
@pvanbuijtene
Copy link
Contributor Author

@anGie44 the documentation is updated.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 9, 2020
@anGie44 anGie44 merged commit 33b7eb9 into hashicorp:master Jun 9, 2020
anGie44 added a commit that referenced this pull request Jun 9, 2020
@anGie44 anGie44 modified the milestones: Roadmap, v2.66.0 Jun 9, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

This has been released in version 2.66.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: WAFv2 Rule Group Data Source
4 participants