Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_dms_endpoint: Add kafka_settings configuration block and kafka to engine_name validation #12835

Merged
merged 1 commit into from
Apr 29, 2020
Merged

resource/aws_dms_endpoint: Add kafka_settings configuration block and kafka to engine_name validation #12835

merged 1 commit into from
Apr 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12836

Release note for CHANGELOG:

* resource/aws_dms_endpoint: Add kafka_settings configuration block and kafka to engine_name validation

Also expands and organizes the resource configuration block documentation.

Output from acceptance testing:

--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (27.99s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (28.18s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (28.43s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (28.58s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (28.86s)
--- PASS: TestAccAwsDmsEndpoint_Basic (28.94s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (29.24s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (29.25s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (35.75s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (38.06s)
--- PASS: TestAccAwsDmsEndpoint_S3 (39.34s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (83.57s)

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 15, 2020
@bflad bflad requested a review from a team April 15, 2020 20:41
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Apr 15, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2020
@bflad bflad linked an issue Apr 15, 2020 that may be closed by this pull request
DMS Endpoint Support for Kafka #12836
Closed
@bflad
resource/aws_dms_endpoint: Add kafka_settings configuration block and…
2792fc0 
… kafka to engine_name validation

Also expands and organizes the resource configuration block documentation.

Output from acceptance testing:

```
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (27.99s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (28.18s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (28.43s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (28.58s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (28.86s)
--- PASS: TestAccAwsDmsEndpoint_Basic (28.94s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (29.24s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (29.25s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (35.75s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (38.06s)
--- PASS: TestAccAwsDmsEndpoint_S3 (39.34s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (83.57s)
```
@bflad
Copy link
Contributor Author

bflad commented Apr 20, 2020

Rebased documentation after merging #12899

gdavison
gdavison approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAwsDmsEndpoint_Basic (14.95s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (15.57s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (17.48s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (18.87s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (19.41s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (25.00s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (28.21s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (30.19s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (33.47s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (33.77s)
--- PASS: TestAccAwsDmsEndpoint_S3 (37.33s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (69.30s)

@bflad bflad added this to the v2.60.0 milestone Apr 29, 2020
@bflad bflad merged commit 4fb01d5 into master Apr 29, 2020
@bflad bflad deleted the f-aws_dms_endpoint-kafka branch April 29, 2020 23:46
bflad added a commit that referenced this pull request Apr 29, 2020
@bflad
Update CHANGELOG for #12835
15d56f2
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.

DMS Endpoint Support for Kafka
2 participants
@bflad @gdavison