fix tagging for default route table

[DrFaust92]

• add plan time validation

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12839

Release note for CHANGELOG:

resource_aws_route_table: add plan time validation to `cidr_block` and `ipv6_cidr_block`
resource_aws_default_route_table: add plan time validation to `cidr_block` and `ipv6_cidr_block`
resource_aws_default_route_table: fix tag on create

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDefaultRouteTable_'
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (40.32s)
--- PASS: TestAccAWSDefaultRouteTable_Route (168.88s)
--- PASS: TestAccAWSDefaultRouteTable_swap (137.80s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (319.80s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (89.90s)
--- PASS: TestAccAWSDefaultRouteTable_tags (153.86s)

$ make testacc TESTARGS='-run=TestAccAWSRouteTable_'
--- PASS: TestAccAWSRouteTable_basic (147.88s)
--- PASS: TestAccAWSRouteTable_instance (187.01s)
--- PASS: TestAccAWSRouteTable_tags (115.74s)
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (46.56s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (201.41s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (389.70s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (97.22s)

both of these failed because i lack permissions to run these
--- FAIL: TestAccAWSRouteTable_ipv6 (40.87s)
--- FAIL: TestAccAWSRouteTable_vpcPeering (59.77s)

[ewbankkit]

Verified acceptance tests (in non-default region):

$ AWS_DEFAULT_REGION=eu-west-1 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 3 -run=TestAccAWSDefaultRouteTable_ -timeout 120m
=== RUN   TestAccAWSDefaultRouteTable_basic
=== PAUSE TestAccAWSDefaultRouteTable_basic
=== RUN   TestAccAWSDefaultRouteTable_disappears_Vpc
=== PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc
=== RUN   TestAccAWSDefaultRouteTable_Route
=== PAUSE TestAccAWSDefaultRouteTable_Route
=== RUN   TestAccAWSDefaultRouteTable_swap
=== PAUSE TestAccAWSDefaultRouteTable_swap
=== RUN   TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== PAUSE TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== RUN   TestAccAWSDefaultRouteTable_vpc_endpoint
=== PAUSE TestAccAWSDefaultRouteTable_vpc_endpoint
=== RUN   TestAccAWSDefaultRouteTable_tags
=== PAUSE TestAccAWSDefaultRouteTable_tags
=== CONT  TestAccAWSDefaultRouteTable_basic
=== CONT  TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== CONT  TestAccAWSDefaultRouteTable_tags
--- PASS: TestAccAWSDefaultRouteTable_basic (51.74s)
=== CONT  TestAccAWSDefaultRouteTable_vpc_endpoint
--- PASS: TestAccAWSDefaultRouteTable_tags (87.83s)
=== CONT  TestAccAWSDefaultRouteTable_Route
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (60.64s)
=== CONT  TestAccAWSDefaultRouteTable_swap
--- PASS: TestAccAWSDefaultRouteTable_Route (101.34s)
=== CONT  TestAccAWSDefaultRouteTable_disappears_Vpc
--- PASS: TestAccAWSDefaultRouteTable_swap (81.21s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (24.97s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (328.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	328.326s

[bflad]

Looks good, just one failing test after the refactor noted below.

--- PASS: TestAccAWSRouteTable_panicEmptyRoute (22.64s)
--- FAIL: TestAccAWSRouteTable_tags (33.75s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (38.90s)
--- PASS: TestAccAWSDefaultRouteTable_basic (39.32s)
--- PASS: TestAccAWSRouteTable_ipv6 (39.96s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (42.10s)
--- PASS: TestAccAWSRouteTableAssociation_disappears (50.10s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (59.92s)
--- PASS: TestAccAWSDefaultRouteTable_swap (62.11s)
--- PASS: TestAccAWSRouteTable_basic (67.29s)
--- PASS: TestAccAWSDefaultRouteTable_tags (68.33s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (69.21s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (70.06s)
--- PASS: TestAccAWSDefaultRouteTable_Route (70.54s)
--- PASS: TestAccAWSRouteTable_vpcPeering (37.75s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (36.95s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (80.32s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeSubnet (83.56s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeGateway (86.26s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (89.87s)
--- PASS: TestAccAWSRouteTable_instance (97.47s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (310.91s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (290.51s)

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDefaultRouteTable_basic (71.32s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (20.89s)
--- PASS: TestAccAWSDefaultRouteTable_Route (78.48s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (324.64s)
--- PASS: TestAccAWSDefaultRouteTable_swap (81.21s)
--- PASS: TestAccAWSDefaultRouteTable_tags (64.92s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (59.84s)

--- PASS: TestAccAWSRouteTable_basic (66.72s)
--- PASS: TestAccAWSRouteTable_instance (122.60s)
--- PASS: TestAccAWSRouteTable_ipv6 (38.35s)
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (21.71s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (76.01s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (301.75s)
--- PASS: TestAccAWSRouteTable_tags (42.91s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (46.29s)
--- PASS: TestAccAWSRouteTable_vpcPeering (60.86s)

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!